Skip to content

stolostron/multicluster-global-hub: use go1.26-linux builder for release-2.14#81355

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
birsanv:acm-go1.26-multicluster-global-hub-1.5
Jul 2, 2026
Merged

stolostron/multicluster-global-hub: use go1.26-linux builder for release-2.14#81355
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
birsanv:acm-go1.26-multicluster-global-hub-1.5

Conversation

@birsanv

@birsanv birsanv commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Bump OpenShift CI build_root from go1.25-linux to go1.26-linux for stolostron-multicluster-global-hub-release-2.14

Why

Companion to GH 1.5 hub go.mod bump — release-2.14 Prow jobs using from: src need go1.26-linux after hub go.mod moves to 1.26.3.

Follows #81274 / #81354 pattern.

Test plan

  • ci/prow/checkconfig passes
  • /pj-rehearse pull-ci-stolostron-multicluster-global-hub-release-2.14-sonarcloud after hub PR merges

Made with Cursor

Made with Cursor

Summary by CodeRabbit

This update changes the OpenShift CI build root used for stolostron-multicluster-global-hub-release-2.14 from go1.25-linux to go1.26-linux. In practical terms, it aligns the release-2.14 Prow jobs with the newer Go toolchain needed after the hub repo’s go.mod moves to Go 1.26.3, helping from: src jobs continue to build correctly.

…ase-2.14

Companion to GH 1.5 go.mod bump — release-2.14 Prow jobs using from: src
need go1.26-linux after hub go.mod moves to 1.26.3.

Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: Valentina Birsan <vbirsan@redhat.com>
@birsanv

birsanv commented Jul 1, 2026

Copy link
Copy Markdown
Contributor Author

Update: go1.26-linux builder for release-2.14

@coderabbitai

coderabbitai Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: c4b8d155-333b-4e81-bbcc-7475d4511834

📥 Commits

Reviewing files that changed from the base of the PR and between 9699520 and 20a8537.

📒 Files selected for processing (1)
  • ci-operator/config/stolostron/multicluster-global-hub/stolostron-multicluster-global-hub-release-2.14.yaml

Walkthrough

The build_root image stream tag in the multicluster-global-hub release-2.14 CI configuration was updated from go1.25-linux to go1.26-linux. No other configuration, test definitions, or workflows were changed.

Changes

CI Builder Image Update

Layer / File(s) Summary
Update build root Go image tag
ci-operator/config/stolostron/multicluster-global-hub/stolostron-multicluster-global-hub-release-2.14.yaml
The build_root.image_stream_tag.tag value is changed from go1.25-linux to go1.26-linux.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

  • openshift/release#81350: Same type of change bumping the build_root.image_stream_tag.tag to Go 1.26 in a different CI config file.
🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the builder image bump to go1.26-linux for release-2.14.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed Only a CI config YAML changed build_root to go1.26-linux; no Ginkgo test titles or test files were added/modified.
Test Structure And Quality ✅ Passed Only a ci-operator YAML build_root tag changed; no Ginkgo test code or test patterns were modified, so the checklist is not applicable.
Microshift Test Compatibility ✅ Passed PR only changes a ci-operator build_root image tag in YAML; no new Ginkgo tests or MicroShift-sensitive API usage were added.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR only updates ci-operator build_root to go1.26-linux; no Ginkgo e2e tests or SNO-sensitive logic were added or changed.
Topology-Aware Scheduling Compatibility ✅ Passed Only the ci-operator build_root image tag changed; no deployment manifests, controllers, affinities, nodeSelectors, or PDBs were modified.
Ote Binary Stdout Contract ✅ Passed Only a ci-operator YAML build_root tag changed; no process-level code, init/setup, or stdout writes were added.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The PR only updates a CI build_root image tag in YAML; no new Ginkgo/e2e tests or network logic were added, so this check is not applicable.
No-Weak-Crypto ✅ Passed PASS: The only PR change is a CI build_root image tag bump in YAML; no crypto algorithms, custom crypto, or secret comparisons were added.
Container-Privileges ✅ Passed The only change is build_root tag go1.25-linux→go1.26-linux; recursive scan found no privileged, hostPID/network/ipc, or allowPrivilegeEscalation fields.
No-Sensitive-Data-In-Logs ✅ Passed Only the build_root builder tag changed; no new or modified logging that could expose secrets or PII was introduced.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 1, 2026
@openshift-ci openshift-ci Bot requested review from MacdonEm and bjoydeep July 1, 2026 18:20
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@birsanv: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-stolostron-multicluster-global-hub-release-2.14-images stolostron/multicluster-global-hub presubmit Ci-operator config changed
pull-ci-stolostron-multicluster-global-hub-release-2.14-sonarcloud stolostron/multicluster-global-hub presubmit Ci-operator config changed
pull-ci-stolostron-multicluster-global-hub-release-2.14-test-e2e stolostron/multicluster-global-hub presubmit Ci-operator config changed
pull-ci-stolostron-multicluster-global-hub-release-2.14-test-integration stolostron/multicluster-global-hub presubmit Ci-operator config changed
pull-ci-stolostron-multicluster-global-hub-release-2.14-test-unit stolostron/multicluster-global-hub presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@birsanv

birsanv commented Jul 1, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@birsanv: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@bjoydeep

bjoydeep commented Jul 2, 2026

Copy link
Copy Markdown

/lgtm /approve

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 2, 2026
@openshift-ci

openshift-ci Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: birsanv, bjoydeep

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@openshift-ci

openshift-ci Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: birsanv, bjoydeep

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-merge-bot Bot pushed a commit to stolostron/multicluster-global-hub that referenced this pull request Jul 2, 2026
…2609)

Pin e2e.yml ginkgo install to v2.28.1 (matching go.mod) to clear S8545
in branch post-submit SonarCloud scans. Follows pinned go install pattern
used for gci/gofumpt in go.yml on this branch.

Companion to openshift/release#81355 go1.26-linux builder bump.

Signed-off-by: Valentina Birsan <vbirsan@redhat.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@birsanv

birsanv commented Jul 2, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@birsanv: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@birsanv

birsanv commented Jul 2, 2026

Copy link
Copy Markdown
Contributor Author

Update: rehearsal failures diagnosed

  • sonarcloud still fails quality gate (S8545 / Security Rating C): #2609 pinned @v2.28.1 in e2e.yml, but SonarCloud needs the go install tool + go.mod tool block pattern from #2608 — follow-up hub PR opened on release-2.14
  • test-integration failed on flaky backup pvc / update pvc which need backup timeout (120s); unrelated to the go1.26-linux builder bump
  • test-unit and images rehearsals passed

Same as #81354: acking rehearsals to unblock merge of this ci-operator-only change; sonar fix lands on hub branch separately.

/pj-rehearse ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@birsanv: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 2, 2026
@openshift-ci

openshift-ci Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

@birsanv: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/stolostron/multicluster-global-hub/release-2.14/sonarcloud 20a8537 link unknown /pj-rehearse pull-ci-stolostron-multicluster-global-hub-release-2.14-sonarcloud
ci/rehearse/stolostron/multicluster-global-hub/release-2.14/test-integration 20a8537 link unknown /pj-rehearse pull-ci-stolostron-multicluster-global-hub-release-2.14-test-integration

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit 43e89b9 into openshift:main Jul 2, 2026
17 of 19 checks passed
openshift-merge-bot Bot pushed a commit to stolostron/multicluster-global-hub that referenced this pull request Jul 2, 2026
Replace pinned go install in e2e.yml with go install tool and add
ginkgo to the go.mod tool block. Clears SonarCloud S8545 on branch
scans; follows the same pattern as #2608 on release-2.13.

Supersedes the incomplete fix in #2609 for openshift/release#81355.

Signed-off-by: Valentina Birsan <vbirsan@redhat.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants