stolostron/multicluster-global-hub: use go1.26-linux builder for release-2.14#81355
Conversation
…ase-2.14 Companion to GH 1.5 go.mod bump — release-2.14 Prow jobs using from: src need go1.26-linux after hub go.mod moves to 1.26.3. Co-authored-by: Cursor <cursoragent@cursor.com> Signed-off-by: Valentina Birsan <vbirsan@redhat.com>
|
Update: go1.26-linux builder for release-2.14
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
WalkthroughThe build_root image stream tag in the multicluster-global-hub release-2.14 CI configuration was updated from go1.25-linux to go1.26-linux. No other configuration, test definitions, or workflows were changed. ChangesCI Builder Image Update
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[REHEARSALNOTIFIER]
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals. Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse |
|
@birsanv: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/lgtm /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: birsanv, bjoydeep The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: birsanv, bjoydeep The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…2609) Pin e2e.yml ginkgo install to v2.28.1 (matching go.mod) to clear S8545 in branch post-submit SonarCloud scans. Follows pinned go install pattern used for gci/gofumpt in go.yml on this branch. Companion to openshift/release#81355 go1.26-linux builder bump. Signed-off-by: Valentina Birsan <vbirsan@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
|
/pj-rehearse |
|
@birsanv: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
Update: rehearsal failures diagnosed
Same as #81354: acking rehearsals to unblock merge of this ci-operator-only change; sonar fix lands on hub branch separately. /pj-rehearse ack |
|
@birsanv: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@birsanv: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
43e89b9
into
openshift:main
Replace pinned go install in e2e.yml with go install tool and add ginkgo to the go.mod tool block. Clears SonarCloud S8545 on branch scans; follows the same pattern as #2608 on release-2.13. Supersedes the incomplete fix in #2609 for openshift/release#81355. Signed-off-by: Valentina Birsan <vbirsan@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Summary
build_rootfromgo1.25-linuxtogo1.26-linuxforstolostron-multicluster-global-hub-release-2.14Why
Companion to GH 1.5 hub go.mod bump —
release-2.14Prow jobs usingfrom: srcneed go1.26-linux after hubgo.modmoves to 1.26.3.Follows #81274 / #81354 pattern.
Test plan
ci/prow/checkconfigpasses/pj-rehearse pull-ci-stolostron-multicluster-global-hub-release-2.14-sonarcloudafter hub PR mergesMade with Cursor
Made with Cursor
Summary by CodeRabbit
This update changes the OpenShift CI build root used for
stolostron-multicluster-global-hub-release-2.14fromgo1.25-linuxtogo1.26-linux. In practical terms, it aligns the release-2.14 Prow jobs with the newer Go toolchain needed after the hub repo’sgo.modmoves to Go 1.26.3, helpingfrom: srcjobs continue to build correctly.