Skip to content

OCPBUGS-127573: Enable topology node selection drawer & fix topology control bar - #519

Draft
pcbailey wants to merge 1 commit into
openshift:mainfrom
pcbailey:fix-nmstate-drawer
Draft

pcbailey wants to merge 1 commit into
openshift:mainfrom
pcbailey:fix-nmstate-drawer

Conversation

@pcbailey

Copy link
Copy Markdown

Description:

Fixes two issues in the Node network configuration topology view:

  1. Node click handler now opens the drawer

    • TopologyDrawer now checks for both CREATE_POLICY_QUERY_PARAM and SELECTED_ID_QUERY_PARAM
    • When a node is clicked, the SELECTION_EVENT sets selectedID in the URL
    • The drawer now opens to display node details via StateDetailsPage
    • Close drawer function clears both query parameters
    • Drawer positioned on the right side per design spec
    • Added close icon button in the upper right corner of the drawer
    • Drawer closes when clicking outside using ref-based click detection
  2. Control bar buttons (zoom in/out, fit, reset) now work

    • Created TopologyControlBarWrapper component that uses useVisualizationController hook
    • The hook properly retrieves the controller from VisualizationProvider context
    • Previously, the ControlBar was receiving null controller and returning null

Jira: https://redhat.atlassian.net/browse/OCPBUGS-127573

Demo:

Before

After

Created with help from: Claude

Fixes two issues in the Node network configuration topology view:

1. Node click handler now opens the drawer
   - TopologyDrawer now checks for both CREATE_POLICY_QUERY_PARAM and SELECTED_ID_QUERY_PARAM
   - When a node is clicked, the SELECTION_EVENT sets selectedID in the URL
   - The drawer now opens to display node details via StateDetailsPage
   - Close drawer function clears both query parameters
   - Drawer positioned on the right side per design spec
   - Added close icon button in the upper right corner of the drawer
   - Drawer closes when clicking outside using ref-based click detection

2. Control bar buttons (zoom in/out, fit, reset) now work
   - Created TopologyControlBarWrapper component that uses useVisualizationController hook
   - The hook properly retrieves the controller from VisualizationProvider context
   - Previously, the ControlBar was receiving null controller and returning null

Fixes: OCPBUGS-127573

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@openshift-merge-bot

Copy link
Copy Markdown

Pipeline controller notification

This PR uses the pipeline controller for second-stage tests. Selection and triggering follow the repository configuration.

Use /test ? to list jobs and /pipeline help for commands.

@openshift-ci

openshift-ci Bot commented Nov 18, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 18, 2026
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 18, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@pcbailey: This pull request references Jira Issue OCPBUGS-127573, which is invalid:

  • expected the bug to target the "5.1.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Description:

Fixes two issues in the Node network configuration topology view:

  1. Node click handler now opens the drawer
  • TopologyDrawer now checks for both CREATE_POLICY_QUERY_PARAM and SELECTED_ID_QUERY_PARAM
  • When a node is clicked, the SELECTION_EVENT sets selectedID in the URL
  • The drawer now opens to display node details via StateDetailsPage
  • Close drawer function clears both query parameters
  • Drawer positioned on the right side per design spec
  • Added close icon button in the upper right corner of the drawer
  • Drawer closes when clicking outside using ref-based click detection
  1. Control bar buttons (zoom in/out, fit, reset) now work
  • Created TopologyControlBarWrapper component that uses useVisualizationController hook
  • The hook properly retrieves the controller from VisualizationProvider context
  • Previously, the ControlBar was receiving null controller and returning null

Jira: https://redhat.atlassian.net/browse/OCPBUGS-127573

Demo:

Before

After

Created with help from: Claude

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Nov 18, 2026

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Central YAML; Path: .coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 5ca98dac-eb85-4b08-a6d0-f1aed8a393ae

@openshift-ci

openshift-ci Bot commented Nov 18, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pcbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 18, 2026
@pcbailey

Copy link
Copy Markdown
Author

/test all

@pcbailey

Copy link
Copy Markdown
Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 18, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@pcbailey: This pull request references Jira Issue OCPBUGS-127573, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (5.1.0) matches configured target version for branch (5.1.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @lkladnit

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
openshift-ci Bot requested a review from lkladnit November 18, 2026 02:57
@openshift-ci

openshift-ci Bot commented Nov 18, 2026

Copy link
Copy Markdown

@pcbailey: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants