Repository navigation
Conversation
Fixes two issues in the Node network configuration topology view: 1. Node click handler now opens the drawer - TopologyDrawer now checks for both CREATE_POLICY_QUERY_PARAM and SELECTED_ID_QUERY_PARAM - When a node is clicked, the SELECTION_EVENT sets selectedID in the URL - The drawer now opens to display node details via StateDetailsPage - Close drawer function clears both query parameters - Drawer positioned on the right side per design spec - Added close icon button in the upper right corner of the drawer - Drawer closes when clicking outside using ref-based click detection 2. Control bar buttons (zoom in/out, fit, reset) now work - Created TopologyControlBarWrapper component that uses useVisualizationController hook - The hook properly retrieves the controller from VisualizationProvider context - Previously, the ControlBar was receiving null controller and returning null Fixes: OCPBUGS-127573 Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
|
Pipeline controller notification This PR uses the pipeline controller for second-stage tests. Selection and triggering follow the repository configuration. Use |
|
Skipping CI for Draft Pull Request. |
|
@pcbailey: This pull request references Jira Issue OCPBUGS-127573, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pcbailey The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test all |
|
/jira refresh |
|
@pcbailey: This pull request references Jira Issue OCPBUGS-127573, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@pcbailey: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Description:
Fixes two issues in the Node network configuration topology view:
Node click handler now opens the drawer
Control bar buttons (zoom in/out, fit, reset) now work
Jira: https://redhat.atlassian.net/browse/OCPBUGS-127573
Demo:
Before
After
Created with help from: Claude