Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Awaiting openshift/console#14621 to finish. Currently the plugin is unable to be loaded due to @patternfly/react-core not being found in the shared modules.
No typescript, compilation, linting or test errors.
This is a 2 version upgrade so there needs to be extensive manual and preferably more automated testing completed once the console and the SDK are using PF6.
Known regression in search-select.tsx where it is not able to create new items.
Codegen for the PF5 => PF6 didn't upgrade many of the PF5 css variables in css or scss files. Instead the suggestion of the upgrade is to look to remove as many overrides of CSS as possible to make upgrades easier in the future. We will need to decide how we want to handle that part of the upgrade, either by following the suggestion or updating the CSS ourselves, but the theming will be different in PF6 so there will need to be additional changes regardless