Skip to content

Conversation

@PeterYurkovich
Copy link
Contributor

@PeterYurkovich PeterYurkovich commented Dec 20, 2024

Awaiting openshift/console#14621 to finish. Currently the plugin is unable to be loaded due to @patternfly/react-core not being found in the shared modules.

No typescript, compilation, linting or test errors.

This is a 2 version upgrade so there needs to be extensive manual and preferably more automated testing completed once the console and the SDK are using PF6.

Known regression in search-select.tsx where it is not able to create new items.

Codegen for the PF5 => PF6 didn't upgrade many of the PF5 css variables in css or scss files. Instead the suggestion of the upgrade is to look to remove as many overrides of CSS as possible to make upgrades easier in the future. We will need to decide how we want to handle that part of the upgrade, either by following the suggestion or updating the CSS ourselves, but the theming will be different in PF6 so there will need to be additional changes regardless

@openshift-ci-robot
Copy link

@PeterYurkovich: This pull request explicitly references no jira issue.

Details

In response to this:

Awaiting openshift/console#14621 to finish. Currently the plugin is unable to be loaded due to @patternfly/react-core not being found in the shared modules.

No typescript, compilation, linting or test errors.

Work isn't near completion, and this is a 2 version upgrade so there needs to be extensive manual and preferably more automated testing completed once the console is using PF6.

Known regression in search-select.tsx where it is not able to create new items.

Codegen for the PF5 => PF6 didn't upgrade many of the PF5 css variables in css or scss files. Instead the suggestion of the upgrade is to look to remove as many overrides of CSS as possible to make upgrades easier in the future.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 20, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 20, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 20, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: PeterYurkovich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants