CORS-4064, CORS-4187: Add support for multi zonal NAT gateways #9773
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@rna-afk: This pull request references CORS-4064 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
rna-afk
force-pushed
the
azure_multi_zonal_nat_gateway
branch
4 times, most recently
from
ec3602c to
e18526f
Compare
rna-afk
force-pushed
the
azure_multi_zonal_nat_gateway
branch
3 times, most recently
from
43a70a3 to
72a16de
Compare
rna-afk
changed the title
|
@rna-afk: This pull request references CORS-4064 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. This pull request references CORS-4187 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@rna-afk: This pull request references CORS-4064 which is a valid jira issue. This pull request references CORS-4187 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest |
rna-afk
changed the title
openshift-ci
bot
added
the
do-not-merge/work-in-progress
rna-afk
force-pushed
the
azure_multi_zonal_nat_gateway
branch
from
72a16de to
c9719c8
Compare
rna-afk
force-pushed
the
azure_multi_zonal_nat_gateway
branch
3 times, most recently
from
1028092 to
15bcb23
Compare
rna-afk
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
rna-afk
force-pushed
the
azure_multi_zonal_nat_gateway
branch
4 times, most recently
from
de423e3 to
14ee71a
Compare
|
This is looking pretty good to me. What do you think @patrickdillon and @sadasu ? |
|
/test verify-codegen |
updating capz to latest commit that has the upstream PR enabling the setting of zone in the nat gateways.
Adding support to install multiple NAT gateways per subnet in the specific zones they need to be in. Also, allowing the users to bring their own subnets. (NAT gateways on BYO subnets are not supported by CAPZ, it just creates a dummy NAT gateway and doesn't attach it to the subnet).
|
Sorry for the confusion: you do need to run |
rna-afk
force-pushed
the
azure_multi_zonal_nat_gateway
branch
from
14ee71a to
1ed30f0
Compare
|
/lgtm I'll wait for feedback from @patrickdillon and @sadasu before /approve |
|
/assign |
Distributing the compute subnets across NAT gateways. Depends on nat gateway availability zones and vm zones.
rna-afk
force-pushed
the
azure_multi_zonal_nat_gateway
branch
from
1ed30f0 to
13b9636
Compare
|
/lgtm |
|
Tested with latest change, all functions are currently working well, no other issue have been found. /verified by jima |
openshift-ci-robot
added
the
verified
|
@jinyunma: This PR has been marked as verified by In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jhixson74 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-merge-bot
bot
merged commit e8da62a
into
openshift:main
|
@rna-afk: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
8 participants
Adding support to install multiple NAT gateways per subnet.
The zone in which they will be installed is not customizable
due to needing an upstream PR to fix CAPZ.