Skip to content

Conversation

csrwng
Copy link
Contributor

@csrwng csrwng commented Aug 15, 2025

What this PR does / why we need it:

  • Add request-serving e2e suite under test/reqserving-e2e and helpers in test/e2e/util/reqserving
  • Add runner script hack/run-reqserving-e2e.sh and update Dockerfile.e2e/Makefile targets
  • Refactor cmd/install/install_render.go so that it can be invoked from e2e.
  • Vendor autoscaler APIs and update go.mod/go.sum/vendor/modules.txt
    Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
    Fixes #

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

- Add request-serving e2e suite under `test/reqserving-e2e` and helpers in `test/e2e/util/reqserving`
- Add runner script `hack/run-reqserving-e2e.sh` and update `Dockerfile.e2e`/`Makefile` targets
- Refactor `cmd/install/install_render.go` so that it can be invoked from e2e.
- Vendor autoscaler APIs and update `go.mod`/`go.sum`/`vendor/modules.txt`

Signed-off-by: Cesar Wong <[email protected]>
Assisted-by: GPT-5 (via Cursor)
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 15, 2025
Copy link
Contributor

openshift-ci bot commented Aug 15, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added do-not-merge/needs-area area/ci-tooling Indicates the PR includes changes for CI or tooling area/cli Indicates the PR includes changes for CLI labels Aug 15, 2025
Copy link
Contributor

openshift-ci bot commented Aug 15, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csrwng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added area/testing Indicates the PR includes changes for e2e testing approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/needs-area labels Aug 15, 2025
Copy link
Contributor

openshift-ci bot commented Sep 4, 2025

@csrwng: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-4-20 8ff025e link true /test e2e-aws-4-20
ci/prow/e2e-aks-4-20 8ff025e link true /test e2e-aks-4-20

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ci-tooling Indicates the PR includes changes for CI or tooling area/cli Indicates the PR includes changes for CLI area/testing Indicates the PR includes changes for e2e testing do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant