-
Notifications
You must be signed in to change notification settings - Fork 665
CONSOLE-4846: add Trusted Software Supply Chain to Getting Started card #15744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@rhamilto: This pull request references CONSOLE-4846 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
WalkthroughInitialize quick-start catalog filter from the URL Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro Cache: Disabled due to data retention organization setting Knowledge base: Disabled due to 📒 Files selected for processing (4)
🚧 Files skipped from review as they are similar to previous changes (4)
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes an existing bug where the keyword query parameter was not being applied to the catalog when navigating from another page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
frontend/packages/console-app/src/components/quick-starts/QuickStartCatalogPage.tsx (1)
19-24: Consider syncing filter with URL changes.The current implementation reads the keyword query parameter only when the component mounts (when
setFilteris initialized). If the URL query parameter changes while the component remains mounted, the filter won't update.If users can navigate between different keyword URLs without remounting this component, consider adding the keyword to the dependency array or using a routing library's hook to track URL changes:
React.useEffect(() => { const keyword = getQueryArgument('keyword'); if (keyword && setFilter) { setFilter('keyword', keyword); + } else if (!keyword && setFilter) { + setFilter('keyword', ''); } -}, [setFilter]); +}, [setFilter, keyword]);Note: You'll need to call
getQueryArgument('keyword')outside the effect to include it in dependencies, or use a URL-watching mechanism.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting
📒 Files selected for processing (3)
frontend/packages/console-app/src/components/quick-starts/QuickStartCatalogPage.tsx(2 hunks)frontend/public/components/dashboard/dashboards-page/cluster-dashboard/getting-started/explore-admin-features-getting-started-card.tsx(1 hunks)frontend/public/locales/en/public.json(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
**
⚙️ CodeRabbit configuration file
-Focus on major issues impacting performance, readability, maintainability and security. Avoid nitpicks and avoid verbosity.
Files:
frontend/public/components/dashboard/dashboards-page/cluster-dashboard/getting-started/explore-admin-features-getting-started-card.tsxfrontend/public/locales/en/public.jsonfrontend/packages/console-app/src/components/quick-starts/QuickStartCatalogPage.tsx
🔇 Additional comments (3)
frontend/packages/console-app/src/components/quick-starts/QuickStartCatalogPage.tsx (1)
2-8: LGTM!The imports are appropriate for implementing URL-based filtering of quick starts.
frontend/public/locales/en/public.json (1)
429-430: LGTM!The translation entries are properly formatted and align with the new feature link in the Getting Started card.
frontend/public/components/dashboard/dashboards-page/cluster-dashboard/getting-started/explore-admin-features-getting-started-card.tsx (1)
35-40: The link is correctly implemented and will work as designed.The code properly extracts the keyword parameter and passes it to PatternFly's QuickStartCatalogPage for filtering. Quick starts are loaded as Kubernetes resources (ConsoleQuickStart CRs) from the cluster, not hardcoded in the frontend. If no quick starts match the "trusted" keyword, the page displays QuickStartEmptyState—this is normal expected behavior, not an error. The link follows the same pattern used elsewhere in the codebase (e.g., TopologyQuickSearch.tsx line 53).
Whether specific quick starts with the "trusted" keyword exist in your deployment is a runtime concern managed separately from the frontend code. The link implementation is sound.
Likely an incorrect or invalid review comment.
|
@rhamilto: This pull request references CONSOLE-4846 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
code approval: |
|
@rhamilto: GitHub didn't allow me to assign the following users: jseseCCS. Note that only openshift members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/label px-approved |
|
/lgtm |
|
/verified by @sg00dwin |
|
@sg00dwin: This PR has been marked as verified by In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
cc @alanonthegit 3.1 “Go to Operators → OperatorHub” should be “Go to Ecosystem → Software Catalog” Step 3.4 |
|
@XiyunZhao please help validate, thanks! |
|
/retest |
4230667 to
bd8a916
Compare
bd8a916 to
fe2d81d
Compare
|
@rhamilto If my assumption is right that only public.json contains any user-facing content, then this lgtm! |
|
/label docs-approved |
jseseCCS
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/label docs-approved
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jseseCCS, rhamilto, sg00dwin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@rhamilto: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/verified by @XiyunZhao |
|
@XiyunZhao: This PR has been marked as verified by In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Note the associated
QuickStartswere added to the console-operator with openshift/console-operator#1062, but they may not yet be appearing in builds.After
Screen.Recording.2025-11-19.at.1.22.13.PM.mov