Skip to content

Conversation

@danwinship
Copy link
Contributor

ovn-kubernetes and our build of kube-proxy both currently special-case openshift-dns to give it "prefer same node" semantics. As of k8s 1.34 / OCP 4.22, we can do this in a standard way by adding "trafficDistribution: PreferSameNode" to the openshift-dns service.

(trafficDistribution itself is GA as of k8s 1.33, PreferSameNode is Beta in 1.34 and already GA upstream in 1.35.)

(ovn-k probably won't implement trafficDistribution in 4.22, but merging this now will let us get rid of a patch for kube-proxy in openshift/kubernetes.)

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 15, 2026
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 15, 2026

@danwinship: This pull request references NE-2414 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

ovn-kubernetes and our build of kube-proxy both currently special-case openshift-dns to give it "prefer same node" semantics. As of k8s 1.34 / OCP 4.22, we can do this in a standard way by adding "trafficDistribution: PreferSameNode" to the openshift-dns service.

(trafficDistribution itself is GA as of k8s 1.33, PreferSameNode is Beta in 1.34 and already GA upstream in 1.35.)

(ovn-k probably won't implement trafficDistribution in 4.22, but merging this now will let us get rid of a patch for kube-proxy in openshift/kubernetes.)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from Miciah and candita January 15, 2026 15:55
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 15, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign miciah for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@danwinship
Copy link
Contributor Author

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 16, 2026

@danwinship: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants