OCPCLOUD-2717: Removing references to DeleteOnTermination

[mdbooth]

This requires removing references to DeleteOnTermination, which was deprecated and renamed in openshift/api#2341.

[damdo]

Matt go mod tidy && go mod vendor shows issues

[damdo]

Thanks

/approve

left a comment about the go mod issue.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damdo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [damdo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[damdo]

It looks like the fuzzy test is not happy, it still is expecting json matching for:

      "blockDevices": [
        {
          "ebs": {
            "deleteOnTermination": false,

[openshift-ci]

@mdbooth: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/unit	1fd7572	link	true	/test unit
ci/prow/regression-clusterinfra-cucushift-rehearse-capi-aws-ipi	1fd7572	link	false	/test regression-clusterinfra-cucushift-rehearse-capi-aws-ipi
ci/prow/e2e-azure-ovn-techpreview	1fd7572	link	false	/test e2e-azure-ovn-techpreview
ci/prow/e2e-aws-ovn	1fd7572	link	true	/test e2e-aws-ovn
ci/prow/e2e-aws-ovn-techpreview-upgrade	1fd7572	link	true	/test e2e-aws-ovn-techpreview-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[damdo]

@mdbooth this needs rebasing when you have some time now that #341 merged

[openshift-merge-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[damdo]

The openshift/api has been bumped in the meantime already by #341
But we can still clean up the DeleteOnTermination references, now (DeprecatedDeleteOnTermination)
So if you can rebase and fix up that'd be great! TY

/retitle Removing references to DeleteOnTermination

[shellyyang1989]

/retitle OCPCLOUD-2717: Removing references to DeleteOnTermination

[shellyyang1989]

/retitle OCPCLOUD-2717: Removing references to DeleteOnTermination

[openshift-ci-robot]

@mdbooth: This pull request references OCPCLOUD-2717 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

This requires removing references to DeleteOnTermination, which was deprecated and renamed in openshift/api#2341.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.