Skip to content

cluster-capi-operator owns the objects it loads from manifests #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

cluster-capi-operator owns the objects it loads from manifests #261

wants to merge 3 commits into from

Conversation

@mdbooth
Copy link
Contributor

@mdbooth mdbooth commented Feb 18, 2025 •
edited
Loading

This makes a change in how cluster-capi-operator manages the objects it has loaded from manifests. Previously it watched any object with a CAPI infrastructure provider label. With this change it now watches any object that it created, regardless of the CAPI infrastructure provider label.

Merge first:

@mdbooth
Apply provider manifests with SSA
a77bfe4
@mdbooth
Only reconcile capi_installer for spec changes
41daec5 
We were unconditionally triggering reconciles for all modifications to
any managed object. This was producing a large number of unnecessary
reconciles when the status of managed objects was updated.
@mdbooth
ClusterOperator owns all objects created by CapiInstallerController
29845d2
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 18, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign damdo for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 15, 2025

@mdbooth: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/regression-clusterinfra-cucushift-rehearse-capi-aws-ipi 29845d2 link false /test regression-clusterinfra-cucushift-rehearse-capi-aws-ipi
ci/prow/lint 29845d2 link true /test lint
ci/prow/e2e-aws-ovn-serial 29845d2 link true /test e2e-aws-ovn-serial
ci/prow/okd-scos-e2e-aws-ovn 29845d2 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-openstack-ovn-techpreview 29845d2 link true /test e2e-openstack-ovn-techpreview

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 15, 2025
@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Apr 15, 2025

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mdbooth
Copy link
Contributor Author

mdbooth commented May 12, 2025

/hold until pre-requisites merge

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 12, 2025
@mdbooth
Copy link
Contributor Author

mdbooth commented May 12, 2025

Replaced by #293

@mdbooth mdbooth closed this May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RadekManak RadekManak Awaiting requested review from RadekManak

@theobarberbany theobarberbany Awaiting requested review from theobarberbany

Assignees

No one assigned

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mdbooth @openshift-merge-robot