Skip to content

OCPBUGS-55673: Remove IngressControllerLBSubnetsAWS featuregate #2400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

OCPBUGS-55673: Remove IngressControllerLBSubnetsAWS featuregate #2400

wants to merge 1 commit into from

Conversation

grzpiotrowski
Copy link

The IngressControllerLBSubnetsAWS feature gate was at first introduced as TPNU in OpenShift 4.17 and was promoted to Default in the same release. The feature gate has been enabled by default for 3 releases and it is scheduled to be removed.

This PR depends on the merge of: openshift/cluster-ingress-operator#1242

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 10, 2025

Hello @grzpiotrowski! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jul 10, 2025
@openshift-ci-robot
Copy link

@grzpiotrowski: This pull request references Jira Issue OCPBUGS-55673, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.0) matches configured target version for branch (4.20.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @lihongan

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

The IngressControllerLBSubnetsAWS feature gate was at first introduced as TPNU in OpenShift 4.17 and was promoted to Default in the same release. The feature gate has been enabled by default for 3 releases and it is scheduled to be removed.

This PR depends on the merge of: openshift/cluster-ingress-operator#1242

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from lihongan July 10, 2025 18:47
@openshift-ci openshift-ci bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jul 10, 2025
@openshift-ci openshift-ci bot requested review from everettraven and JoelSpeed July 10, 2025 18:48
@grzpiotrowski grzpiotrowski force-pushed the OCPBUGS-55673-remove-ic-lb-subnets-aws-featuregate branch from af3ae97 to 1f8364b Compare July 10, 2025 20:04
@grzpiotrowski grzpiotrowski force-pushed the OCPBUGS-55673-remove-ic-lb-subnets-aws-featuregate branch from 1f8364b to 5a3f389 Compare July 24, 2025 11:57
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 24, 2025
@grzpiotrowski
OCPBUGS-55673: Remove IngressControllerLBSubnetsAWS featuregate
64b9aad 
The IngressControllerLBSubnetsAWS feature gate was at first introduced
as TPNU in OpenShift 4.17 and was promoted to Default in the same
release. The feature gate has been enabled by default for 3 releases,
so it is scheduled to be removed imminently.

This commit addresses OCPBUGS-55673:
https://issues.redhat.com/browse/OCPBUGS-55673
@grzpiotrowski grzpiotrowski force-pushed the OCPBUGS-55673-remove-ic-lb-subnets-aws-featuregate branch from 5a3f389 to 64b9aad Compare July 24, 2025 12:45
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 24, 2025
@JoelSpeed
Copy link
Contributor

/lgtm

Assuming all goes green, this is good to go

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 24, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grzpiotrowski, JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 24, 2025
@grzpiotrowski
Copy link
Author

Assuming all goes green, this is good to go

Thank you @JoelSpeed.
I believe that openshift/cluster-ingress-operator#1242 will need to go in first? Review pending on our side.

@JoelSpeed
Copy link
Contributor

/hold until openshift/cluster-ingress-operator#1242 merges

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 24, 2025
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD f313adb and 2 for PR HEAD 64b9aad in total

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 24, 2025

@grzpiotrowski: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-serial-techpreview-1of2 64b9aad link true /test e2e-aws-serial-techpreview-1of2
ci/prow/minor-e2e-upgrade-minor 64b9aad link true /test minor-e2e-upgrade-minor
ci/prow/okd-scos-e2e-aws-ovn 64b9aad link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-aws-ovn-hypershift-conformance 64b9aad link true /test e2e-aws-ovn-hypershift-conformance
ci/prow/e2e-aws-ovn-hypershift 64b9aad link true /test e2e-aws-ovn-hypershift
ci/prow/e2e-aws-ovn 64b9aad link true /test e2e-aws-ovn
ci/prow/e2e-azure 64b9aad link false /test e2e-azure
ci/prow/e2e-gcp 64b9aad link false /test e2e-gcp
ci/prow/e2e-aws-serial-2of2 64b9aad link true /test e2e-aws-serial-2of2
ci/prow/e2e-aws-serial-techpreview-2of2 64b9aad link true /test e2e-aws-serial-techpreview-2of2
ci/prow/e2e-upgrade 64b9aad link true /test e2e-upgrade
ci/prow/e2e-aws-serial-1of2 64b9aad link true /test e2e-aws-serial-1of2
ci/prow/e2e-upgrade-out-of-change 64b9aad link true /test e2e-upgrade-out-of-change
ci/prow/e2e-aws-ovn-techpreview 64b9aad link true /test e2e-aws-ovn-techpreview

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lihongan lihongan Awaiting requested review from lihongan

@everettraven everettraven Awaiting requested review from everettraven

1 more reviewer

@JoelSpeed JoelSpeed JoelSpeed left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@JoelSpeed JoelSpeed

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@grzpiotrowski @openshift-ci-robot @JoelSpeed @openshift-merge-robot