-
Notifications
You must be signed in to change notification settings - Fork 26
feat: Enable 'All' namespaces view for non-admin users #633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Show 'All' option in namespace dropdown for all users with accessible namespaces - Remove admin-only restriction from pipelines overview pages - Non-admins see pipeline data scoped to their accessible namespaces - Maintains security through existing RBAC permissions Fixes: SRVKP-6766
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mathur07 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
The solution is based on the understanding that :
|
|
Hey @vikram-raj @lokanandaprabhu @pratap0007 and @aThorp96, I have this SRVKP-6766 that needs refinement. I was looking through the code and saw that it may be possible to implement it through the changes in this PR. I would need your advice to guide me if this change will be the correct fix to address "Show 'All' option in namespace dropdown for non-admin users with respective accessible namespaces". If not, then what is the correct approach that should be followed to achieve the desired states. Based on that we will be able to break the story into tasks and epics. TY! |
|
@mathur07: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@mathur07 |
Fixes: SRVKP-6766