Skip to content

Conversation

@mathur07
Copy link

@mathur07 mathur07 commented Aug 26, 2025

  • Show 'All' option in namespace dropdown for all users with accessible namespaces
  • Remove admin-only restriction from pipelines overview pages
  • Non-admins see pipeline data scoped to their accessible namespaces
  • Maintains security through existing RBAC permissions

Fixes: SRVKP-6766

- Show 'All' option in namespace dropdown for all users with accessible namespaces
- Remove admin-only restriction from pipelines overview pages
- Non-admins see pipeline data scoped to their accessible namespaces
- Maintains security through existing RBAC permissions

Fixes: SRVKP-6766
@openshift-ci openshift-ci bot requested review from Lucifergene and saumeya August 26, 2025 19:06
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 26, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mathur07
Once this PR has been reviewed and has the lgtm label, please assign vdemeester for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mathur07 mathur07 marked this pull request as draft August 26, 2025 19:07
@mathur07
Copy link
Author

The solution is based on the understanding that :

  • useK8sWatchResource<Project[]> only returns projects the current user can access
  • All the pipeline queries (when ALL_NAMESPACES_KEY is selected) will be scoped to those accessible namespaces

@mathur07
Copy link
Author

mathur07 commented Aug 26, 2025

Hey @vikram-raj @lokanandaprabhu @pratap0007 and @aThorp96, I have this SRVKP-6766 that needs refinement. I was looking through the code and saw that it may be possible to implement it through the changes in this PR. I would need your advice to guide me if this change will be the correct fix to address "Show 'All' option in namespace dropdown for non-admin users with respective accessible namespaces". If not, then what is the correct approach that should be followed to achieve the desired states. Based on that we will be able to break the story into tasks and epics. TY!

@mathur07 mathur07 marked this pull request as ready for review September 3, 2025 16:22
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 3, 2025

@mathur07: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/build a3a1cbc link true /test build
ci/prow/images a3a1cbc link true /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@anwesha-palit-redhat
Copy link
Contributor

@mathur07
Can you please add a before and after screen recording for the same ? Also please add unit tests, if possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants