Updating references from ROSA Regional Platform to ROSA HyperFleet#665
Merged
Conversation
Contributor
📝 WalkthroughWalkthroughGlobal rename of all ChangesROSA Regional Platform → HyperFleet Rename
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Possibly related PRs
Suggested labels
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: typeid The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
Collaborator
|
/test on-demand-e2e |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/adding-component-pre-merge.md`:
- Line 106: Replace the generic link text in the onboarding step with
descriptive text so it passes MD059 and is easier to scan. Update the sentence
in the component pre-merge guide to use meaningful link text instead of “here”,
while keeping the reference to the ci-operator config path example intact.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 6d675830-2633-4e85-b27a-39c147f6e837
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (76)
.ambient/ci-analyser-agent/README.md.ambient/documentation-update-agent/README.md.claude/agents/adversary.md.claude/agents/architect.md.claude/agents/ci-troubleshooter.md.claude/agents/documentation-updater.md.claude/commands/jira.new.md.claude/skills/add-pre-merge/SKILL.md.claude/skills/ic/SKILL.md.github/workflows/review-dashboard.yml.spec/001-agent-vm-isolation/egress-proxy-spec.yaml.spec/002-spec-to-pr-agent/context-requirements.md.spec/002-spec-to-pr-agent/requirements.mdCLAUDE.mdMakefileREADME.mdargocd/README.mdargocd/config/management-cluster/maestro-agent/Chart.yamlargocd/config/management-cluster/vector/Chart.yamlargocd/config/regional-cluster/alerting-rules/Chart.yamlargocd/config/regional-cluster/loki/Chart.yamlargocd/config/regional-cluster/maestro-server/Chart.yamlargocd/config/regional-cluster/platform-api/README.mdargocd/config/regional-cluster/thanos/Chart.yamlargocd/config/regional-cluster/vector/Chart.yamlargocd/config/shared/zoa-jobs/Chart.yamlargocd/config/shared/zoa-jobs/values.yamlci/Containerfileci/README.mdci/e2e-tests.shci/ephemeral-provider/README.mdci/ephemeral-provider/main.pyci/janitor/README.mdci/janitor/aws-nuke-config.yamldashboard/fetch-data.shdashboard/index.htmldocs/FAQ.mddocs/README.mddocs/adding-component-pre-merge.mddocs/blog/blog-milestone-4-observability.mddocs/design/alerting-architecture.mddocs/design/aws-iam-hosted-cluster-authentication.mddocs/design/dns-architecture.mddocs/design/fips-eks-compute.mddocs/design/fully-private-eks-bootstrap.mddocs/design/gitops-cluster-configuration.mddocs/design/logging-platform.mddocs/design/maestro-mqtt-resource-distribution.mddocs/design/monitoring-platform.mddocs/design/pipeline-based-lifecycle.mddocs/design/regional-account-minting.mddocs/design/terraform-resource-adoption.mddocs/design/testing-strategy.mddocs/design/zoa-trusted-actions.mddocs/development-environment.mddocs/environment-provisioning.mddocs/hostedcluster-provisioning.mddocs/process/ic.mddocs/sop/rebuild-integration.mdhack/pr-report.shhack/zoa.shscripts/bootstrap-central-account.shscripts/dev/env-common.shscripts/dev/ephemeral-env.shscripts/dev/int-env.shscripts/ic/collect-data.pyterraform/config/central-account-bootstrap/main.tfterraform/config/management-cluster/terraform.tfvars.exampleterraform/config/regional-cluster/terraform.tfvars.exampleterraform/modules/api-gateway/variables.tfterraform/modules/bastion/README.mdterraform/modules/bastion/jumphost-task.tfterraform/modules/ecs-bootstrap/variables.tfterraform/modules/eks-cluster/README.mdterraform/modules/hyperfleet-infrastructure/README.mdterraform/modules/pagerduty-service/variables.tf
| ### Step 2: Add CI config in openshift/release to your repository's job config | ||
|
|
||
| Edit `ci-operator/config/<repo>/<org>-<repo>-<branch>.yaml`, e.g. [here](https://github.com/openshift/release/pull/76818/changes#diff-e1f3e71b4382080dfc304ae3b05b7cc97e95f2bf6cf49d744c4901fdc55274e1) for [rosa-regional-platform-api](https://github.com/openshift-online/rosa-regional-platform-api): | ||
| Edit `ci-operator/config/<repo>/<org>-<repo>-<branch>.yaml`, e.g. [here](https://github.com/openshift/release/pull/76818/changes#diff-e1f3e71b4382080dfc304ae3b05b7cc97e95f2bf6cf49d744c4901fdc55274e1) for [rosa-hyperfleet-api](https://github.com/openshift-online/rosa-hyperfleet-api): |
Contributor
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Use descriptive link text.
here trips MD059 and makes the onboarding step harder to scan.
♻️ Proposed fix
- Edit ci-operator/config/<repo>/<org>-<repo>-<branch>.yaml, e.g. [here](...) for [rosa-hyperfleet-api](...)
+ Edit ci-operator/config/<repo>/<org>-<repo>-<branch>.yaml, e.g. [the rosa-hyperfleet-api example CI config](...) for [rosa-hyperfleet-api](...)📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| Edit `ci-operator/config/<repo>/<org>-<repo>-<branch>.yaml`, e.g. [here](https://github.com/openshift/release/pull/76818/changes#diff-e1f3e71b4382080dfc304ae3b05b7cc97e95f2bf6cf49d744c4901fdc55274e1) for [rosa-hyperfleet-api](https://github.com/openshift-online/rosa-hyperfleet-api): | |
| Edit `ci-operator/config/<repo>/<org>-<repo>-<branch>.yaml`, e.g. [the rosa-hyperfleet-api example CI config](https://github.com/openshift/release/pull/76818/changes#diff-e1f3e71b4382080dfc304ae3b05b7cc97e95f2bf6cf49d744c4901fdc55274e1) for [rosa-hyperfleet-api](https://github.com/openshift-online/rosa-hyperfleet-api): |
🧰 Tools
🪛 markdownlint-cli2 (0.22.1)
[warning] 106-106: Link text should be descriptive
(MD059, descriptive-link-text)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@docs/adding-component-pre-merge.md` at line 106, Replace the generic link
text in the onboarding step with descriptive text so it passes MD059 and is
easier to scan. Update the sentence in the component pre-merge guide to use
meaningful link text instead of “here”, while keeping the reference to the
ci-operator config path example intact.
Source: Linters/SAST tools
Contributor
There was a problem hiding this comment.
Actionable comments posted: 4
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
.ambient/ci-analyser-agent/README.md (1)
49-98: 🎯 Functional Correctness | 🟠 Major | ⚡ Quick winRoute PR operations to the selected repository.
Step 2 can send the fix to
rosa-hyperfleet-api, but the sync/create/comment commands here are hard-coded toopenshift-online/rosa-hyperfleet. That will open or update PRs in the wrong repository for API-side failures.🔧 Proposed fix
- gh repo sync ${GH_USER}/rosa-hyperfleet --source openshift-online/rosa-hyperfleet + gh repo sync ${GH_USER}/${TARGET_REPO} --source openshift-online/${TARGET_REPO} ... - --repo openshift-online/rosa-hyperfleet \ + --repo openshift-online/${TARGET_REPO} \ ... - --repo openshift-online/rosa-hyperfleet \ + --repo openshift-online/${TARGET_REPO} \🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.ambient/ci-analyser-agent/README.md around lines 49 - 98, The PR workflow commands are hard-coded to the wrong repository, so updates for API-side failures can be sent to the wrong place. Update the repo targets in the README’s branch/PR instructions so the sync, create, and comment steps use the selected repository for this job rather than always pointing at openshift-online/rosa-hyperfleet, and keep the examples consistent with the surrounding CI analyzer flow.README.md (1)
13-29: 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick winAdd a language tag to the fenced tree block.
Markdownlint flags this block because the fence has no language.
textis enough here and keeps the listing readable.Suggested fix
-``` +```text🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@README.md` around lines 13 - 29, Add a language tag to the fenced tree listing in README.md by updating the Markdown fence around the directory tree to use text; keep the existing content unchanged and just adjust the fence so markdownlint accepts it. Locate the block by the repository tree snippet under the top-level README structure and apply the fix to that fenced code block.Source: Linters/SAST tools
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.claude/agents/ci-troubleshooter.md:
- Line 69: The example repository target in ci-troubleshooter.md points to the
wrong source; update the cloned repository reference so it matches the
HyperFleet repo naming used elsewhere in the stack. Adjust the example in the
Step 4 guidance to use the correct repository identifier and URL, keeping the
rest of the workflow unchanged.
In `@docs/adding-component-pre-merge.md`:
- Around line 104-106: The CI config path template in the pre-merge docs is
incorrect and points to the wrong repository layout. Update the template in the
section describing the openshift/release job config to use the same pattern as
the pre-merge template, matching the ci-operator/config path format used by the
documentation and examples. Refer to the existing Step 2 text and the
ci-operator/config template wording so readers are directed to the correct YAML
location.
In `@docs/design/pipeline-based-lifecycle.md`:
- Around line 158-161: The bootstrap example is using the wrong argument name
for scripts/bootstrap-central-account.sh, so update the example to match the
documented interface. Replace the TARGET_ENVIRONMENT usage with the script’s
expected ENVIRONMENT positional argument in the example, keeping
GITHUB_REPOSITORY and GITHUB_BRANCH as-is, so the snippet reflects how
bootstrap-central-account.sh is actually invoked.
In `@docs/design/regional-account-minting.md`:
- Around line 11-27: The YAML example in the regional account minting doc is
malformed because several region entries are left as hanging scalars under the
mapped values. Update the example under the regional account minting section so
the nested structure for rosa-hyperfleet, staging-1, and staging-2 is explicit
and each region/value pair is properly indented and keyed, keeping the snippet
valid and copy/pasteable.
---
Outside diff comments:
In @.ambient/ci-analyser-agent/README.md:
- Around line 49-98: The PR workflow commands are hard-coded to the wrong
repository, so updates for API-side failures can be sent to the wrong place.
Update the repo targets in the README’s branch/PR instructions so the sync,
create, and comment steps use the selected repository for this job rather than
always pointing at openshift-online/rosa-hyperfleet, and keep the examples
consistent with the surrounding CI analyzer flow.
In `@README.md`:
- Around line 13-29: Add a language tag to the fenced tree listing in README.md
by updating the Markdown fence around the directory tree to use text; keep the
existing content unchanged and just adjust the fence so markdownlint accepts it.
Locate the block by the repository tree snippet under the top-level README
structure and apply the fix to that fenced code block.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 6d675830-2633-4e85-b27a-39c147f6e837
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (76)
.ambient/ci-analyser-agent/README.md.ambient/documentation-update-agent/README.md.claude/agents/adversary.md.claude/agents/architect.md.claude/agents/ci-troubleshooter.md.claude/agents/documentation-updater.md.claude/commands/jira.new.md.claude/skills/add-pre-merge/SKILL.md.claude/skills/ic/SKILL.md.github/workflows/review-dashboard.yml.spec/001-agent-vm-isolation/egress-proxy-spec.yaml.spec/002-spec-to-pr-agent/context-requirements.md.spec/002-spec-to-pr-agent/requirements.mdCLAUDE.mdMakefileREADME.mdargocd/README.mdargocd/config/management-cluster/maestro-agent/Chart.yamlargocd/config/management-cluster/vector/Chart.yamlargocd/config/regional-cluster/alerting-rules/Chart.yamlargocd/config/regional-cluster/loki/Chart.yamlargocd/config/regional-cluster/maestro-server/Chart.yamlargocd/config/regional-cluster/platform-api/README.mdargocd/config/regional-cluster/thanos/Chart.yamlargocd/config/regional-cluster/vector/Chart.yamlargocd/config/shared/zoa-jobs/Chart.yamlargocd/config/shared/zoa-jobs/values.yamlci/Containerfileci/README.mdci/e2e-tests.shci/ephemeral-provider/README.mdci/ephemeral-provider/main.pyci/janitor/README.mdci/janitor/aws-nuke-config.yamldashboard/fetch-data.shdashboard/index.htmldocs/FAQ.mddocs/README.mddocs/adding-component-pre-merge.mddocs/blog/blog-milestone-4-observability.mddocs/design/alerting-architecture.mddocs/design/aws-iam-hosted-cluster-authentication.mddocs/design/dns-architecture.mddocs/design/fips-eks-compute.mddocs/design/fully-private-eks-bootstrap.mddocs/design/gitops-cluster-configuration.mddocs/design/logging-platform.mddocs/design/maestro-mqtt-resource-distribution.mddocs/design/monitoring-platform.mddocs/design/pipeline-based-lifecycle.mddocs/design/regional-account-minting.mddocs/design/terraform-resource-adoption.mddocs/design/testing-strategy.mddocs/design/zoa-trusted-actions.mddocs/development-environment.mddocs/environment-provisioning.mddocs/hostedcluster-provisioning.mddocs/process/ic.mddocs/sop/rebuild-integration.mdhack/pr-report.shhack/zoa.shscripts/bootstrap-central-account.shscripts/dev/env-common.shscripts/dev/ephemeral-env.shscripts/dev/int-env.shscripts/ic/collect-data.pyterraform/config/central-account-bootstrap/main.tfterraform/config/management-cluster/terraform.tfvars.exampleterraform/config/regional-cluster/terraform.tfvars.exampleterraform/modules/api-gateway/variables.tfterraform/modules/bastion/README.mdterraform/modules/bastion/jumphost-task.tfterraform/modules/ecs-bootstrap/variables.tfterraform/modules/eks-cluster/README.mdterraform/modules/hyperfleet-infrastructure/README.mdterraform/modules/pagerduty-service/variables.tf
| 2. Find the commit hash from the `provision-ephemeral` build log: | ||
| ``` | ||
| Cloned at 4f3ef1fb56583f9c3ad3be022ee896b3ff66fe37 (https://github.com/typeid/rosa-regional-platform/tree/4f3ef1fb) | ||
| Cloned at 4f3ef1fb56583f9c3ad3be022ee896b3ff66fe37 (https://github.com/typeid/rosa-hyperfleet/tree/4f3ef1fb) |
Contributor
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Fix the example repository target.
typeid/rosa-hyperfleet doesn't match the HyperFleet repo naming used elsewhere in this stack, so this example will send the agent to the wrong source when it follows Step 4.
♻️ Proposed fix
- Cloned at 4f3ef1fb56583f9c3ad3be022ee896b3ff66fe37 (https://github.com/typeid/rosa-hyperfleet/tree/4f3ef1fb)
+ Cloned at 4f3ef1fb56583f9c3ad3be022ee896b3ff66fe37 (https://github.com/openshift-online/rosa-hyperfleet/tree/4f3ef1fb)📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| Cloned at 4f3ef1fb56583f9c3ad3be022ee896b3ff66fe37 (https://github.com/typeid/rosa-hyperfleet/tree/4f3ef1fb) | |
| Cloned at 4f3ef1fb56583f9c3ad3be022ee896b3ff66fe37 (https://github.com/openshift-online/rosa-hyperfleet/tree/4f3ef1fb) |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.claude/agents/ci-troubleshooter.md at line 69, The example repository
target in ci-troubleshooter.md points to the wrong source; update the cloned
repository reference so it matches the HyperFleet repo naming used elsewhere in
the stack. Adjust the example in the Step 4 guidance to use the correct
repository identifier and URL, keeping the rest of the workflow unchanged.
Comment on lines
104
to
+106
| ### Step 2: Add CI config in openshift/release to your repository's job config | ||
|
|
||
| Edit `ci-operator/config/<repo>/<org>-<repo>-<branch>.yaml`, e.g. [here](https://github.com/openshift/release/pull/76818/changes#diff-e1f3e71b4382080dfc304ae3b05b7cc97e95f2bf6cf49d744c4901fdc55274e1) for [rosa-regional-platform-api](https://github.com/openshift-online/rosa-regional-platform-api): | ||
| Edit `ci-operator/config/<repo>/<org>-<repo>-<branch>.yaml`, e.g. [here](https://github.com/openshift/release/pull/76818/changes#diff-e1f3e71b4382080dfc304ae3b05b7cc97e95f2bf6cf49d744c4901fdc55274e1) for [rosa-hyperfleet-api](https://github.com/openshift-online/rosa-hyperfleet-api): |
Contributor
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Fix the openshift/release path template.
The doc points readers at ci-operator/config/<repo>/<org>-<repo>-<branch>.yaml, but the pre-merge template uses ci-operator/config/<org>/<org>-<repo>-<branch>.yaml. As written, this sends users to the wrong file.
Suggested fix
-Edit `ci-operator/config/<repo>/<org>-<repo>-<branch>.yaml`
+Edit `ci-operator/config/<org>/<org>-<repo>-<branch>.yaml`📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| ### Step 2: Add CI config in openshift/release to your repository's job config | |
| Edit `ci-operator/config/<repo>/<org>-<repo>-<branch>.yaml`, e.g. [here](https://github.com/openshift/release/pull/76818/changes#diff-e1f3e71b4382080dfc304ae3b05b7cc97e95f2bf6cf49d744c4901fdc55274e1) for [rosa-regional-platform-api](https://github.com/openshift-online/rosa-regional-platform-api): | |
| Edit `ci-operator/config/<repo>/<org>-<repo>-<branch>.yaml`, e.g. [here](https://github.com/openshift/release/pull/76818/changes#diff-e1f3e71b4382080dfc304ae3b05b7cc97e95f2bf6cf49d744c4901fdc55274e1) for [rosa-hyperfleet-api](https://github.com/openshift-online/rosa-hyperfleet-api): | |
| ### Step 2: Add CI config in openshift/release to your repository's job config | |
| Edit `ci-operator/config/<org>/<org>-<repo>-<branch>.yaml`, e.g. [here](https://github.com/openshift/release/pull/76818/changes#diff-e1f3e71b4382080dfc304ae3b05b7cc97e95f2bf6cf49d744c4901fdc55274e1) for [rosa-hyperfleet-api](https://github.com/openshift-online/rosa-hyperfleet-api): |
🧰 Tools
🪛 markdownlint-cli2 (0.22.1)
[warning] 106-106: Link text should be descriptive
(MD059, descriptive-link-text)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@docs/adding-component-pre-merge.md` around lines 104 - 106, The CI config
path template in the pre-merge docs is incorrect and points to the wrong
repository layout. Update the template in the section describing the
openshift/release job config to use the same pattern as the pre-merge template,
matching the ci-operator/config path format used by the documentation and
examples. Refer to the existing Step 2 text and the ci-operator/config template
wording so readers are directed to the correct YAML location.
Comment on lines
+158
to
161
| GITHUB_REPOSITORY=openshift-online/rosa-hyperfleet \ | ||
| GITHUB_BRANCH=main \ | ||
| TARGET_ENVIRONMENT=staging \ | ||
| ./scripts/bootstrap-central-account.sh |
Contributor
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Use the script's documented bootstrap arguments.
Line 158 sets TARGET_ENVIRONMENT, but scripts/bootstrap-central-account.sh documents ENVIRONMENT as the positional argument. As written, this only works because staging is the default, so the example is misleading.
🛠️ Suggested fix
GITHUB_REPOSITORY=openshift-online/rosa-hyperfleet \
GITHUB_BRANCH=main \
-TARGET_ENVIRONMENT=staging \
-./scripts/bootstrap-central-account.sh
+./scripts/bootstrap-central-account.sh \
+ openshift-online/rosa-hyperfleet \
+ main \
+ staging📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| GITHUB_REPOSITORY=openshift-online/rosa-hyperfleet \ | |
| GITHUB_BRANCH=main \ | |
| TARGET_ENVIRONMENT=staging \ | |
| ./scripts/bootstrap-central-account.sh | |
| GITHUB_REPOSITORY=openshift-online/rosa-hyperfleet \ | |
| GITHUB_BRANCH=main \ | |
| ./scripts/bootstrap-central-account.sh \ | |
| openshift-online/rosa-hyperfleet \ | |
| main \ | |
| staging |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@docs/design/pipeline-based-lifecycle.md` around lines 158 - 161, The
bootstrap example is using the wrong argument name for
scripts/bootstrap-central-account.sh, so update the example to match the
documented interface. Replace the TARGET_ENVIRONMENT usage with the script’s
expected ENVIRONMENT positional argument in the example, keeping
GITHUB_REPOSITORY and GITHUB_BRANCH as-is, so the snippet reflects how
bootstrap-central-account.sh is actually invoked.
Comment on lines
+11
to
27
| rosa-hyperfleet: | ||
| prod: prod-us-east-1 | ||
| prod-eu-west-2 | ||
| ... | ||
|
|
||
| staging-1: | ||
| rosa-regional-platform: | ||
| rosa-hyperfleet: | ||
| int: int-us-east-2 | ||
| stage: stage-us-east-1 | ||
| stage-eu-west-2 | ||
| ... | ||
|
|
||
| staging-2: | ||
| rosa-regional-platform: | ||
| rosa-hyperfleet: | ||
| dev: dev-kirk-us-east-2 | ||
| dev-pete-eu-west-1 | ||
| ... |
Contributor
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Restore valid YAML structure in the example.
Lines 11-27 no longer parse as YAML: entries like prod-eu-west-2 and stage-eu-west-2 are hanging as bare scalars. Keep the nesting explicit so the snippet stays copy/pasteable.
🛠️ Suggested fix
control:
rosa-hyperfleet:
- prod: prod-us-east-1
- prod-eu-west-2
- ...
+ prod:
+ - prod-us-east-1
+ - prod-eu-west-2
+ - ...
staging-1:
rosa-hyperfleet:
- int: int-us-east-2
- stage: stage-us-east-1
- stage-eu-west-2
- ...
+ int:
+ - int-us-east-2
+ stage:
+ - stage-us-east-1
+ - stage-eu-west-2
+ - ...
staging-2:
rosa-hyperfleet:
- dev: dev-kirk-us-east-2
- dev-pete-eu-west-1
- ...
+ dev:
+ - dev-kirk-us-east-2
+ - dev-pete-eu-west-1
+ - ...📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| rosa-hyperfleet: | |
| prod: prod-us-east-1 | |
| prod-eu-west-2 | |
| ... | |
| staging-1: | |
| rosa-regional-platform: | |
| rosa-hyperfleet: | |
| int: int-us-east-2 | |
| stage: stage-us-east-1 | |
| stage-eu-west-2 | |
| ... | |
| staging-2: | |
| rosa-regional-platform: | |
| rosa-hyperfleet: | |
| dev: dev-kirk-us-east-2 | |
| dev-pete-eu-west-1 | |
| ... | |
| rosa-hyperfleet: | |
| prod: | |
| - prod-us-east-1 | |
| - prod-eu-west-2 | |
| - ... | |
| staging-1: | |
| rosa-hyperfleet: | |
| int: | |
| - int-us-east-2 | |
| stage: | |
| - stage-us-east-1 | |
| - stage-eu-west-2 | |
| - ... | |
| staging-2: | |
| rosa-hyperfleet: | |
| dev: | |
| - dev-kirk-us-east-2 | |
| - dev-pete-eu-west-1 | |
| - ... |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@docs/design/regional-account-minting.md` around lines 11 - 27, The YAML
example in the regional account minting doc is malformed because several region
entries are left as hanging scalars under the mapped values. Update the example
under the regional account minting section so the nested structure for
rosa-hyperfleet, staging-1, and staging-2 is explicit and each region/value pair
is properly indented and keyed, keeping the snippet valid and copy/pasteable.
Contributor
Author
|
/test on-demand-e2e |
1 similar comment
Contributor
Author
|
/test on-demand-e2e |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating repo references from ROSA Regional Platform to ROSA HyperFleet besides the following points:
But the dev scripts have been updated since they were failing to resolve the internal repo and the accounts.
Summary by CodeRabbit