Skip to content

Update repository list and bot authors in fetch-data.sh #650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
iamkirkbater wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update repository list and bot authors in fetch-data.sh #650

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions dashboard/fetch-data.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,10 @@ SCRIPT_DIR="$(cd "$(dirname "$0")" && pwd)"
OUT="${SCRIPT_DIR}/data.json"

REPOS=(
openshift-online/rosa-regional-platform
openshift-online/rosa-regional-platform-api
openshift-online/rosa-regional-platform-cli
openshift-online/rosa-regional-platform-internal
openshift-online/rosa-hyperfleet
openshift-online/rosa-hyperfleet-api
openshift-online/rosa-hyperfleet-cli
openshift-online/rosa-hyperfleet-internal
Comment on lines +15 to +18

@coderabbitai coderabbitai Bot Jun 25, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win

Update frontend repo shorthand mapping to match new repo names.

REPOS now emits rosa-hyperfleet* repository names, but dashboard/index.html still maps only rosa-regional-platform* in SHORT (Line 257-301). This can regress display labels in the dashboard.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@dashboard/fetch-data.sh` around lines 15 - 18, The dashboard shorthand
mapping is out of date and only recognizes the old rosa-regional-platform
repository names, so update the SHORT mapping in dashboard/index.html to include
the new rosa-hyperfleet variants emitted by REPOS. Keep the existing label
behavior, but add or replace the entries so the repository-name-to-display-name
lookup in the mapping correctly handles rosa-hyperfleet, rosa-hyperfleet-api,
rosa-hyperfleet-cli, and rosa-hyperfleet-internal.

)

JSON_FIELDS="number,title,author,labels,reviewRequests,createdAt,updatedAt,url"
Expand Down Expand Up @@ -48,7 +48,7 @@ fetch_label "review-ready" > /tmp/rr.json
echo "Fetching discussion-needed PRs..."
fetch_label "discussion-needed" > /tmp/dn.json

BOT_AUTHORS="app/dependabot|rosa-regional-platform-ci|rrp-bot"
BOT_AUTHORS="app/dependabot|rosa-hyperfleet-ci|rrp-bot"

@coderabbitai coderabbitai Bot Jun 25, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win

Sync IC process docs with the new bot author identity.

BOT_AUTHORS now matches rosa-hyperfleet-ci, but docs/process/ic.md still references rosa-regional-platform-ci (Line 26-29). Please update the doc so /ok-to-test guidance matches dashboard behavior.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@dashboard/fetch-data.sh` at line 51, The bot author identity used by the
`/ok-to-test` flow is out of sync between the dashboard script and the IC
process docs. Update the `BOT_AUTHORS`-related guidance in `docs/process/ic.md`
to use `rosa-hyperfleet-ci` so it matches the behavior defined in
`fetch-data.sh`, keeping the references to the `/ok-to-test` handling and bot
allowlist consistent.


echo "Fetching needs-ok-to-test PRs (bot authors only)..."
fetch_label "needs-ok-to-test" | jq --arg bots "$BOT_AUTHORS" \
Expand Down