Skip to content

Conversation

@yprokule
Copy link
Contributor

Addresses discrepancy between telco-core/configuration/reference-crs/optional/other/sctp_module_mc.yaml and telco-core/install/extra-manifests/sctp_module_mc.yaml

@openshift-ci
Copy link

openshift-ci bot commented Nov 24, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yprokule
Once this PR has been reviewed and has the lgtm label, please assign lack for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yprokule
Copy link
Contributor Author

/cc @irinamihai

@openshift-ci openshift-ci bot requested a review from irinamihai November 24, 2025 15:01
@yprokule
Copy link
Contributor Author

/assign @irinamihai

@irinamihai
Copy link
Contributor

Hi! I'm not familiar with this specific configuration, but I do have 2 comments:

  1. Why are there 2 identical files? Even if they are used at different times in the cluster lifecycle, if they are identical, I think a symlink would make more sense.
  2. Shouldn't the RAN config also be updated?

/cc @imiller0

@openshift-ci openshift-ci bot requested a review from imiller0 November 25, 2025 20:02
@yprokule yprokule changed the title Align sctp_module_mc.yaml within extra-manigests folder Align sctp_module_mc.yaml within extra-manifests folder Nov 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants