Skip to content

Conversation

@abraham2512
Copy link
Member

@abraham2512 abraham2512 commented Oct 15, 2025

This PR includes updates for merging RAN monitoring configuration with ACM observability.

  • Hub side policy to be applied on observability namespace. Copies the route for alertmanager to the managedcluster CR annotation
  • Updates ReduceMonitoringFootprint reference CR to use URL from the managedcluster annotations

@openshift-ci openshift-ci bot requested review from imiller0 and irinamihai October 15, 2025 15:42
@abraham2512 abraham2512 changed the title telco-ran: get alertmanager url from managed cluster annotation telco-ran: OCPBUGS-63008: get alertmanager url from managed cluster annotation Oct 15, 2025
@openshift-ci-robot
Copy link
Collaborator

@abraham2512: This pull request references Jira Issue OCPBUGS-63008, which is invalid:

  • expected the bug to target the "4.21.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@abraham2512 abraham2512 force-pushed the acm-route-policy-rmf branch 2 times, most recently from b090afb to 28761f2 Compare October 15, 2025 16:07
@abraham2512
Copy link
Member Author

/retest

@openshift-ci-robot
Copy link
Collaborator

@abraham2512: This pull request references Jira Issue OCPBUGS-63008, which is invalid:

  • expected the bug to target the "4.21.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Updates regarding merging RAN monitoring configuration with ACM observability.

  • Policy on the hub side to be applied on observability namespace to copy the route for alertmanager to the managedcluster CR annotations.
  • Updates to the reference CRs to fetch the URL from the managedcluster annotations instead of fromSecret.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@abraham2512 abraham2512 force-pushed the acm-route-policy-rmf branch 3 times, most recently from d63c157 to b284b00 Compare October 15, 2025 19:47
@abraham2512 abraham2512 changed the title telco-ran: OCPBUGS-63008: get alertmanager url from managed cluster annotation telco-ran: OCPBUGS-63008: Improve RAN monitoring footprint CR to get alertmanager url from MCL annotation Oct 16, 2025
@abraham2512
Copy link
Member Author

/cherry-pick release-4.20

@openshift-cherrypick-robot

@abraham2512: once the present PR merges, I will cherry-pick it on top of release-4.20 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@abraham2512
Copy link
Member Author

/ @irinamihai @imiller0

@openshift-ci-robot
Copy link
Collaborator

@abraham2512: This pull request references Jira Issue OCPBUGS-63008, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.21.0) matches configured target version for branch (4.21.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @dgonyier

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This PR includes updates for merging RAN monitoring configuration with ACM observability.

  • Hub side policy to be applied on observability namespace. Copies the route for alertmanager to the managedcluster CR annotation
  • Updates ReduceMonitoringFootprint reference CR to use URL from the managedcluster annotations

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from dgonyier October 28, 2025 18:08
@abraham2512 abraham2512 force-pushed the acm-route-policy-rmf branch 4 times, most recently from 2266c60 to 8888b43 Compare November 16, 2025 22:41
@dgonyier
Copy link

@abraham2512 what is the intended setup and behavior if ACM observability is not enabled on the hub?

@abraham2512
Copy link
Member Author

Hi @dgonyier. If ACM observability is not setup on the hub, this namespace open-cluster-management-addon-observability would not exist on the spoke. Therefore the lookup for alertmanager URL would not occur.
The policy would still remain compliant.

@irinamihai
Copy link
Contributor

/retest

@irinamihai
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 27, 2025
@openshift-ci
Copy link

openshift-ci bot commented Nov 27, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abraham2512, irinamihai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 27, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit d513317 into openshift-kni:main Nov 27, 2025
8 checks passed
@openshift-ci-robot
Copy link
Collaborator

@abraham2512: Jira Issue OCPBUGS-63008: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-63008 has been moved to the MODIFIED state.

In response to this:

This PR includes updates for merging RAN monitoring configuration with ACM observability.

  • Hub side policy to be applied on observability namespace. Copies the route for alertmanager to the managedcluster CR annotation
  • Updates ReduceMonitoringFootprint reference CR to use URL from the managedcluster annotations

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-cherrypick-robot

@abraham2512: #406 failed to apply on top of branch "release-4.20":

Applying: telco-ran: obs-route-policy for annotating mcl with alertmanager url
Applying: add note
Applying: telco-hub: update readme
Applying: telco-ran: add note in kube-compare
Applying: telco-hub: update readme
Using index info to reconstruct a base tree...
M	telco-hub/configuration/reference-crs/required/acm/readme.md
Falling back to patching base and 3-way merge...
Auto-merging telco-hub/configuration/reference-crs/required/acm/readme.md
CONFLICT (content): Merge conflict in telco-hub/configuration/reference-crs/required/acm/readme.md
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0005 telco-hub: update readme

In response to this:

/cherry-pick release-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants