Skip to content

Conversation

@shajmakh
Copy link
Member

@shajmakh shajmakh commented Oct 3, 2025

The recorder by default pushes every new status as long as some capacity constraints are met but it doesn't check whether this status is already reported last. We added option to configure the coalesing on the recorder and by default it is false so we don't limit any client from pushing the same PFPs again. Here we only set this param to true at the begining of the program without need to set it through env var because this is what we expect when the scheduler is recording the statuses.

The recorder by default pushes every new status as long as some
capacity constraints are met but it doesn't check whether this status is
already reported last. We added option to configure the coalesing on the
recorder and by default it is false so we don't limit any client from
pushing the same PFPs again. Here we only set this param to true at the
begining of the program without need to set it through env var because
this is what we expect when the scheduler is recording the statuses.

Signed-off-by: Shereen Haj <[email protected]>
@openshift-ci openshift-ci bot requested review from ffromani and swatisehgal October 3, 2025 07:13
@openshift-ci
Copy link

openshift-ci bot commented Oct 3, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: shajmakh
Once this PR has been reviewed and has the lgtm label, please assign swatisehgal for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@shajmakh
Copy link
Member Author

shajmakh commented Oct 3, 2025

/hold
for openshift-kni/debug-tools#98

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 3, 2025
@openshift-ci
Copy link

openshift-ci bot commented Oct 3, 2025

@shajmakh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ci-unit 56b89f0 link true /test ci-unit
ci/prow/images 56b89f0 link true /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant