Skip to content

Conversation

@pixelsoccupied
Copy link
Collaborator

@pixelsoccupied pixelsoccupied commented Nov 7, 2025

Link alertmanager with resource server to handle hardware monitoring alerts.

  • Add resource server client for alarms service
  • Distinguish between CaaS and hardware alert sources
  • Add internal resource endpoint to resource server API

Need #1308 first to merge

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 7, 2025
@openshift-ci
Copy link

openshift-ci bot commented Nov 7, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci
Copy link

openshift-ci bot commented Nov 7, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign donpenney for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pixelsoccupied pixelsoccupied force-pushed the hardware-alerts-integration branch 5 times, most recently from aae18a5 to 3c9449a Compare November 14, 2025 17:47
@pixelsoccupied pixelsoccupied changed the title Hardware alerts integration CNF-20047: Hardware alerts integration Nov 14, 2025
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Nov 14, 2025

@pixelsoccupied: This pull request references CNF-20047 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.21.0" version, but no target version was set.

In response to this:

Link alertmanager with resource server to handle hardware monitoring alerts.

  • Add resource server client for alarms service
  • Distinguish between CaaS and hardware alert sources
  • Add internal resource endpoint to resource server API
  • Update RBAC for resource types and PrometheusRules access
  • Support alarm source constants (AlarmSourceCaaS, AlarmSourceHardware)

Need #1308 first to merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@pixelsoccupied pixelsoccupied marked this pull request as ready for review November 14, 2025 20:26
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 14, 2025
@pixelsoccupied pixelsoccupied requested review from alegacy and removed request for by2waysprojects and sudomakeinstall2 November 14, 2025 20:27
@pixelsoccupied pixelsoccupied force-pushed the hardware-alerts-integration branch from 3c9449a to daf5872 Compare November 14, 2025 21:02
Link alertmanager with resource server to handle hardware monitoring alerts.

- Add resource server client for alarms service
- Distinguish between CaaS and hardware alert sources
- Add internal resource endpoint to resource server API
- Update RBAC for resource types and PrometheusRules access
- Support alarm source constants (AlarmSourceCaaS, AlarmSourceHardware)

Co-Authored-By: Claude <[email protected]>
@pixelsoccupied pixelsoccupied force-pushed the hardware-alerts-integration branch from daf5872 to a546d5e Compare November 14, 2025 21:18
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Nov 14, 2025

@pixelsoccupied: This pull request references CNF-20047 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.21.0" version, but no target version was set.

In response to this:

Link alertmanager with resource server to handle hardware monitoring alerts.

  • Add resource server client for alarms service
  • Distinguish between CaaS and hardware alert sources
  • Add internal resource endpoint to resource server API

Need #1308 first to merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@pixelsoccupied pixelsoccupied force-pushed the hardware-alerts-integration branch 2 times, most recently from 12d0643 to a5199f0 Compare November 19, 2025 18:55
@pixelsoccupied
Copy link
Collaborator Author

/hold

pushed to the wrong PR....

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 19, 2025
@pixelsoccupied pixelsoccupied force-pushed the hardware-alerts-integration branch from a5199f0 to 15f9598 Compare November 19, 2025 19:00
@pixelsoccupied
Copy link
Collaborator Author

/unhold

should be back now

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants