Skip to content

Conversation

@sebrandon1
Copy link

Similar to: openshift-kni/telco-reference#433

Changes:

  • Adds a quick PR check that attempts to kustomize build appropriate files. Only runs against main.
  • Adds a make path for make test-kustomize which runs the script. Users can run this locally as well as there are safeguards to ensure kustomize exists first.
  • Skips YAMLs that might require external plugins. See EXCLUDED_DIRS.

Example run:

$ make test-kustomize 
hack/test-kustomize.sh
Checking all kustomization.yaml files can build successfully...

  ./config/crd: OK
  ./config/default: OK
  ./config/kind-ci: OK
  ./config/manager: OK
  ./config/manifests: OK
  ./config/networkpolicy: OK
  ./config/prometheus: OK
  ./config/rbac: OK
  ./config/samples: OK
  ./config/scorecard: OK

Summary: Checked 10 kustomization.yaml files, skipped 0 (require external plugins)
All kustomization files validated successfully!

@openshift-ci openshift-ci bot requested review from ffromani and shajmakh October 30, 2025 19:38
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 30, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sebrandon1
Once this PR has been reviewed and has the lgtm label, please assign ffromani for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sebrandon1
Copy link
Author

@ffromani
Copy link
Member

ffromani commented Nov 4, 2025

The CI failure is legit, PTAL.

@sebrandon1 sebrandon1 force-pushed the add_kustomization_test branch from 04ddb36 to 589fcdc Compare November 4, 2025 22:40
@ffromani
Copy link
Member

ffromani commented Nov 5, 2025

Not sure how beneficial is this validation, but should not hurt either

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants