tools: pfpsyncchk: cosmetic cleanup and enhanced output #2218
Conversation
openshift-ci
bot
added
the
approved
ffromani
left a comment
ffromani
left a comment
There was a problem hiding this comment.
I don't like too much the output format itself, but let's fix in another PR.
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ffromani, shajmakh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
no problem, let's sync offline and agree on the best output and I'll handle that in a new PR |
shajmakh
force-pushed
the
cleanup-pfpsyncchk
branch
from
0d764cb to
2b83fa3
Compare
|
New changes are detected. LGTM label has been removed. |
shajmakh
force-pushed
the
cleanup-pfpsyncchk
branch
from
2b83fa3 to
a0156a8
Compare
Inline functions where possible addressing the remaining review comments in openshift-kni#2098. Signed-off-by: Shereen Haj <[email protected]>
remove redundant `knlog.InfoS` and ensure that the final reported PFP status is reflected in the output; as such: ``` ... ***FINAL PFP SYNC STATUSES*** control-plane-1: desynced! control-plane-2: desynced! control-plane-3: desynced! ``` Signed-off-by: Shereen Haj <[email protected]>
|
@shajmakh: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
Please see the commits for more details.