Skip to content

Add kustomize validation check #3097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add kustomize validation check #3097

wants to merge 1 commit into from

Conversation

@sebrandon1
Copy link
Contributor

@sebrandon1 sebrandon1 commented Oct 30, 2025 •
edited
Loading

Note: It looks like Actions aren't enabled for this repo. So it will need to be enabled prior to this being merged.

Similar to: openshift-kni/telco-reference#433

Changes:

  • Adds a quick PR check that attempts to kustomize build appropriate files. Only runs against main.
  • Adds a make path for make test-kustomize which runs the script. Users can run this locally as well as there are safeguards to ensure kustomize exists first.
  • Skips YAMLs that might require external plugins. See EXCLUDED_DIRS.

Example run:

$ make test-kustomize 
Validating kustomization files
hack/test-kustomize.sh
Checking all kustomization.yaml files can build successfully...

  ./cnf-tests/submodules/cluster-node-tuning-operator/examples/performanceprofile/crd: OK
  ./cnf-tests/submodules/cluster-node-tuning-operator/examples/performanceprofile/default: SKIPPED (requires external plugins)
  ./cnf-tests/submodules/cluster-node-tuning-operator/examples/performanceprofile/rbac: OK
  ./cnf-tests/submodules/cluster-node-tuning-operator/examples/performanceprofile/samples: OK
  ./cnf-tests/submodules/cluster-node-tuning-operator/test/e2e/performanceprofile/cluster-setup/base/performance: OK
  ./cnf-tests/submodules/cluster-node-tuning-operator/test/e2e/performanceprofile/cluster-setup/ci-cluster/performance: OK
  ./cnf-tests/submodules/cluster-node-tuning-operator/test/e2e/performanceprofile/cluster-setup/ci-upgrade-test-cluster/performance: OK
  ./cnf-tests/submodules/cluster-node-tuning-operator/test/e2e/performanceprofile/cluster-setup/manual-cluster/arm: OK
  ./cnf-tests/submodules/cluster-node-tuning-operator/test/e2e/performanceprofile/cluster-setup/manual-cluster/cpuFrequency: SKIPPED (requires external plugins)
  ./cnf-tests/submodules/cluster-node-tuning-operator/test/e2e/performanceprofile/cluster-setup/manual-cluster/performance-norps: OK
  ./cnf-tests/submodules/cluster-node-tuning-operator/test/e2e/performanceprofile/cluster-setup/manual-cluster/performance: OK
  ./cnf-tests/submodules/cluster-node-tuning-operator/test/e2e/performanceprofile/cluster-setup/mcp-only-cluster/performance: OK
  ./cnf-tests/submodules/metallb-operator/config/crd: OK
  ./cnf-tests/submodules/metallb-operator/config/default: OK
  ./cnf-tests/submodules/metallb-operator/config/frr-webhook-prometheus: OK
  ./cnf-tests/submodules/metallb-operator/config/manager: OK
  ./cnf-tests/submodules/metallb-operator/config/manifests: OK
  ./cnf-tests/submodules/metallb-operator/config/metallb_rbac: OK
  ./cnf-tests/submodules/metallb-operator/config/olm-install: OK
  ./cnf-tests/submodules/metallb-operator/config/openshift: OK
  ./cnf-tests/submodules/metallb-operator/config/rbac: OK
  ./cnf-tests/submodules/metallb-operator/config/samples: OK
  ./cnf-tests/submodules/metallb-operator/config/scorecard: OK
  ./cnf-tests/submodules/metallb-operator/config/webhook/backend: OK
  ./cnf-tests/submodules/metallb-operator/config/webhook: OK
  ./cnf-tests/submodules/metallb-operator/config/webhook/webhook: OK
  ./cnf-tests/submodules/metallb-operator/hack/ocp-kustomize-overlay: SKIPPED (requires external plugins)
  ./cnf-tests/submodules/metallb-operator/manifests/ocpcsv: SKIPPED (requires external plugins)
  ./cnf-tests/submodules/sriov-network-operator/config/crd: OK
  ./cnf-tests/submodules/sriov-network-operator/config/default: OK
  ./cnf-tests/submodules/sriov-network-operator/config/manager: OK
  ./cnf-tests/submodules/sriov-network-operator/config/manifests: OK
  ./cnf-tests/submodules/sriov-network-operator/config/prometheus: OK
  ./cnf-tests/submodules/sriov-network-operator/config/rbac: OK
  ./cnf-tests/submodules/sriov-network-operator/config/samples: OK
  ./cnf-tests/submodules/sriov-network-operator/config/scorecard: OK
  ./feature-configs/5g-ref-nw/clusters/otwaon1234rd/cu-up-m1: OK
  ./feature-configs/5g-ref-nw/clusters/otwaon1234rd/cu-up-m1/nw-config: OK
  ./feature-configs/5g-ref-nw/clusters/otwaon1234rd/cu-up-m1/nw-config/sriov: OK
  ./feature-configs/5g-ref-nw/clusters/otwaon1234rd/cu-up-m1/role-hardware: OK
  ./feature-configs/5g-ref-nw/clusters/otwaon1234rd/cu-up-m1/role-hardware/performance: OK
  ./feature-configs/5g-ref-nw/clusters/otwaon1234rd/cu-up-m1/role-hardware/ran-general: OK
  ./feature-configs/5g-ref-nw/clusters/otwaon1234rd/du-dc-m1: OK
  ./feature-configs/5g-ref-nw/clusters/otwaon1234rd/du-dc-m1/nw-config: OK
  ./feature-configs/5g-ref-nw/clusters/otwaon1234rd/du-dc-m1/nw-config/sriov: OK
  ./feature-configs/5g-ref-nw/clusters/otwaon1234rd/du-dc-m1/role-hardware: OK
  ./feature-configs/5g-ref-nw/clusters/otwaon1234rd/du-dc-m1/role-hardware/performance: OK
  ./feature-configs/5g-ref-nw/clusters/otwaon1234rd/du-dc-m1/role-hardware/ptp: OK
  ./feature-configs/5g-ref-nw/clusters/otwaon1234rd/du-dc-m1/role-hardware/ran-general: OK
  ./feature-configs/5g-ref-nw/clusters/otwaon1234rd/remote-sites/otwaon23456rw: OK
  ./feature-configs/5g-ref-nw/clusters/otwaon1234rd/remote-sites/otwaon23456rw/nw-config: OK
  ./feature-configs/5g-ref-nw/clusters/otwaon1234rd/remote-sites/otwaon23456rw/nw-config/sriov: OK
  ./feature-configs/5g-ref-nw/clusters/otwaon1234rd/remote-sites/otwaon23456rw/role-hardware: OK
  ./feature-configs/5g-ref-nw/clusters/otwaon1234rd/remote-sites/otwaon23456rw/role-hardware/performance: OK
  ./feature-configs/5g-ref-nw/clusters/otwaon1234rd/remote-sites/otwaon23456rw/role-hardware/ptp: OK
  ./feature-configs/5g-ref-nw/clusters/otwaon1234rd/remote-sites/otwaon23456rw/role-hardware/ran-general: OK
  ./feature-configs/5g-ref-nw/clusters/otwaon34567sno: OK
  ./feature-configs/5g-ref-nw/clusters/otwaon34567sno/nw-config: OK
  ./feature-configs/5g-ref-nw/clusters/otwaon34567sno/nw-config/logging: OK
  ./feature-configs/5g-ref-nw/clusters/otwaon34567sno/nw-config/sriov: OK
  ./feature-configs/5g-ref-nw/clusters/otwaon34567sno/role-hardware: OK
  ./feature-configs/5g-ref-nw/clusters/otwaon34567sno/role-hardware/performance: OK
  ./feature-configs/5g-ref-nw/clusters/otwaon34567sno/role-hardware/ptp: OK
  ./feature-configs/5g-ref-nw/clusters/otwaon34567sno/role-hardware/ran-general: OK
  ./feature-configs/5g-ref-nw/operators/cluster-logging: OK
  ./feature-configs/5g-ref-nw/operators/ptp: OK
  ./feature-configs/5g-ref-nw/operators/sriov: OK
  ./feature-configs/5g-ref-nw/profile-base/cu-up/performance: OK
  ./feature-configs/5g-ref-nw/profile-base/cu-up/sriov: OK
  ./feature-configs/5g-ref-nw/profile-base/du-dual/performance: OK
  ./feature-configs/5g-ref-nw/profile-base/du-dual/sriov: OK
  ./feature-configs/5g-ref-nw/profile-base/du-general: OK
  ./feature-configs/5g-ref-nw/profile-base/du-general/performance: OK
  ./feature-configs/5g-ref-nw/profile-base/du-general/ptp/disable-chronyd: OK
  ./feature-configs/5g-ref-nw/profile-base/du-general/ptp: OK
  ./feature-configs/5g-ref-nw/profile-base/du-single/performance: OK
  ./feature-configs/5g-ref-nw/profile-base/du-single/sriov: OK
  ./feature-configs/5g-ref-nw/profile-base/ran-general/container-mount-namespace: OK
  ./feature-configs/5g-ref-nw/profile-base/ran-general: OK
  ./feature-configs/5g-ref-nw/profile-base/ran-general/sctp: OK
  ./feature-configs/5g-ref-nw/profile-base/sno-general: OK
  ./feature-configs/ci/container-mount-namespace: OK
  ./feature-configs/ci/fec: OK
  ./feature-configs/ci/gatekeeper: OK
  ./feature-configs/ci/knmstate: OK
  ./feature-configs/ci/localhost-workaround: OK
  ./feature-configs/ci/metallb: OK
  ./feature-configs/ci/multinetworkpolicy: OK
  ./feature-configs/ci/n3000: OK
  ./feature-configs/ci/ptp: OK
  ./feature-configs/ci/s2i: OK
  ./feature-configs/ci/sctp: OK
  ./feature-configs/ci/sriov: OK
  ./feature-configs/ci/sro: OK
  ./feature-configs/cn-ran-overlays/ran-profile-gcp: OK
  ./feature-configs/cn-ran-overlays/ran-profile/cluster-config/du-common/performance: OK
  ./feature-configs/cn-ran-overlays/ran-profile/cluster-config/du-common/ptp: OK
  ./feature-configs/cn-ran-overlays/ran-profile/cluster-config: OK
  ./feature-configs/cn-ran-overlays/ran-profile: OK
  ./feature-configs/cn-ran-overlays/ran-profile/site.1.fqdn: OK
  ./feature-configs/cn-ran-overlays/ran-profile/site.1.fqdn/networks: OK
  ./feature-configs/demo/local_bfd: SKIPPED (requires external plugins)
  ./feature-configs/demo/performance: OK
  ./feature-configs/demo/ptp: OK
  ./feature-configs/demo/s2i: OK
  ./feature-configs/demo/sctp: OK
  ./feature-configs/demo/sriov: OK
  ./feature-configs/deploy/container-mount-namespace/container-private-mounts: OK
  ./feature-configs/deploy/container-mount-namespace: OK
  ./feature-configs/deploy/container-mount-namespace/master: OK
  ./feature-configs/deploy/container-mount-namespace/worker: OK
  ./feature-configs/deploy/fec: OK
  ./feature-configs/deploy/gatekeeper: OK
  ./feature-configs/deploy/knmstate: OK
  ./feature-configs/deploy/localhost-workaround: OK
  ./feature-configs/deploy/metallb: OK
  ./feature-configs/deploy/multinetworkpolicy: OK
  ./feature-configs/deploy/n3000: OK
  ./feature-configs/deploy/ptp: OK
  ./feature-configs/deploy/s2i: OK
  ./feature-configs/deploy/sctp: OK
  ./feature-configs/deploy/sriov: OK
  ./feature-configs/deploy/sro: OK
  ./feature-configs/hypershift-ci/metallb: OK
  ./feature-configs/hypershift-ci/multinetworkpolicy: OK
  ./feature-configs/hypershift-ci/ptp: OK
  ./feature-configs/hypershift-ci/s2i: OK
  ./feature-configs/hypershift-ci/sriov: OK
  ./feature-configs/integration-base/performance: OK
  ./feature-configs/integration-base/ptp: OK
  ./feature-configs/integration-base/sctp: OK
  ./feature-configs/integration-base/sriov: OK
  ./feature-configs/integration-kni1/performance: OK
  ./feature-configs/integration-kni1/ptp: OK
  ./feature-configs/integration-kni1/s2i: OK
  ./feature-configs/integration-kni1/sctp: OK
  ./feature-configs/integration-kni1/sriov: OK
  ./feature-configs/integration-u08/performance: OK
  ./feature-configs/integration-u08/ptp: OK
  ./feature-configs/integration-u08/s2i: OK
  ./feature-configs/integration-u08/sctp: OK
  ./feature-configs/integration-u08/sriov: OK
  ./feature-configs/integration-vms/performance: OK
  ./feature-configs/integration-vms/sctp: OK
  ./feature-configs/integration-wl4-d17u01b05/performance: OK
  ./feature-configs/typical-baremetal/container-mount-namespace: OK
  ./feature-configs/typical-baremetal/performance: OK
  ./feature-configs/typical-baremetal/ptp: OK
  ./feature-configs/typical-baremetal/s2i: OK
  ./feature-configs/typical-baremetal/sctp: OK
  ./feature-configs/typical-baremetal/sriov: OK
  ./ztp/gitops-subscriptions/acm: OK
  ./ztp/gitops-subscriptions/argocd/deployment: OK
  ./ztp/gitops-subscriptions/argocd/example/acmpolicygenerator: SKIPPED (requires external plugins)
  ./ztp/gitops-subscriptions/argocd/example/image-based-upgrades: SKIPPED (requires external plugins)
  ./ztp/gitops-subscriptions/argocd/example/policygentemplates: SKIPPED (requires external plugins)
  ./ztp/gitops-subscriptions/argocd/example/siteconfig: SKIPPED (requires external plugins)
  ./ztp/policygenerator-kustomize-plugin: SKIPPED (requires external plugins)
  ./ztp/ran-crd: OK
  ./ztp/resource-generator/telco-reference/telco-core/configuration: SKIPPED (requires external plugins)
  ./ztp/resource-generator/telco-reference/telco-hub/configuration/reference-crs: OK
  ./ztp/resource-generator/telco-reference/telco-hub/configuration/reference-crs/optional/lso: OK
  ./ztp/resource-generator/telco-reference/telco-hub/configuration/reference-crs/optional/odf-internal: OK
  ./ztp/resource-generator/telco-reference/telco-hub/configuration/reference-crs/required/acm: OK
  ./ztp/resource-generator/telco-reference/telco-hub/configuration/reference-crs/required/gitops: OK
  ./ztp/resource-generator/telco-reference/telco-hub/configuration/reference-crs/required/gitops/ztp-installation: OK
  ./ztp/resource-generator/telco-reference/telco-hub/configuration/reference-crs/required/talm: OK
  ./ztp/resource-generator/telco-reference/telco-ran/configuration/argocd/deployment: OK
  ./ztp/resource-generator/telco-reference/telco-ran/configuration/argocd/example/acmpolicygenerator: SKIPPED (requires external plugins)
  ./ztp/resource-generator/telco-reference/telco-ran/configuration/argocd/example/image-based-upgrades: SKIPPED (requires external plugins)
  ./ztp/resource-generator/telco-reference/telco-ran/configuration/argocd/example/policygentemplates: SKIPPED (requires external plugins)
  ./ztp/resource-generator/telco-reference/telco-ran/configuration/argocd/example/siteconfig: SKIPPED (requires external plugins)
  ./ztp/resource-generator/telco-reference/telco-ran/install/clusterinstance: SKIPPED (requires external plugins)
  ./ztp/resource-generator/telco-reference/telco-ran/install/siteconfig: SKIPPED (requires external plugins)
  ./ztp/siteconfig-generator-kustomize-plugin: SKIPPED (requires external plugins)

Summary: Checked 157 kustomization.yaml files, skipped 18 (require external plugins)
All kustomization files validated successfully!

@openshift-ci openshift-ci bot requested review from sabbir-47 and zeeke October 30, 2025 17:26
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 30, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sebrandon1
Once this PR has been reviewed and has the lgtm label, please assign fedepaol for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 30, 2025

@sebrandon1: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ci cfda83d link true /test ci
ci/prow/e2e-aws-ci-tests cfda83d link true /test e2e-aws-ci-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sabbir-47 sabbir-47 Awaiting requested review from sabbir-47

@zeeke zeeke Awaiting requested review from zeeke

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@sebrandon1