-
Notifications
You must be signed in to change notification settings - Fork 38
CNF-20549: [TALM 4.21] : New opm render mechanism for hermetic builds #5092
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@rauhersu: This pull request references CNF-20549 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@rauhersu: This pull request references CNF-20549 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
64751f6 to
8d2ba34
Compare
|
/assign @fontivan |
Why?
Prior to these changes, the catalog generation was performed inside the Dockerfile build, making it non-hermetic and requiring external network access during the build. That violated Konflux's hermetic build requirements and required an exception.
What ?
This PR refactors the fbc pipeline to leverage OPM rendering tasks within the Konflux pipeline, enabling hermetic builds and simplifying the catalog generation process. The changes include:
run-opm-pre-actionsandrun-opm-commandtasks in the FBC pipeline.catalog.yamltocatalog.jsonthroughout the codebase.hermetic: true) in the FBC pipeline.