Skip to content

Conversation

@rauhersu
Copy link
Contributor

@rauhersu rauhersu commented Nov 21, 2025

Why?

Prior to these changes, the catalog generation was performed inside the Dockerfile build, making it non-hermetic and requiring external network access during the build. That violated Konflux's hermetic build requirements and required an exception.

What ?

This PR refactors the fbc pipeline to leverage OPM rendering tasks within the Konflux pipeline, enabling hermetic builds and simplifying the catalog generation process. The changes include:

  • Introduction of run-opm-pre-actions and run-opm-command tasks in the FBC pipeline.
  • Simplification of the catalog Dockerfile to only handle TALM-specific naming fixes.
  • Migration from catalog.yaml to catalog.json throughout the codebase.
  • Addition of ImageDigestMirrorSet (IDMS) configuration for catalog rendering.
  • Enabling hermetic builds (hermetic: true) in the FBC pipeline.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 21, 2025

@rauhersu: This pull request references CNF-20549 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.21.0" version, but no target version was set.

In response to this:

Why?

Prior to these changes, the catalog generation was performed inside the Dockerfile build, making it non-hermetic and requiring external network access during the build. That violated Konflux's hermetic build requirements and required an exception.

What ?

This PR refactors the fbc pipeline to leverage OPM rendering tasks within the Konflux pipeline, enabling hermetic builds and simplifying the catalog generation process. The changes include:

Introduction of run-opm-pre-actions and run-opm-command tasks in the FBC pipeline.
Simplification of the catalog Dockerfile to only handle TALM-specific naming fixes.
Migration from catalog.yaml to catalog.json throughout the codebase.
Addition of ImageDigestMirrorSet (IDMS) configuration for catalog rendering.
Enabling hermetic builds (hermetic: true) in the FBC pipeline.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link

openshift-ci bot commented Nov 21, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign vitus133 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 21, 2025

@rauhersu: This pull request references CNF-20549 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.21.0" version, but no target version was set.

In response to this:

Why?

Prior to these changes, the catalog generation was performed inside the Dockerfile build, making it non-hermetic and requiring external network access during the build. That violated Konflux's hermetic build requirements and required an exception.

What ?

This PR refactors the fbc pipeline to leverage OPM rendering tasks within the Konflux pipeline, enabling hermetic builds and simplifying the catalog generation process. The changes include:

  • Introduction of run-opm-pre-actions and run-opm-command tasks in the FBC pipeline.
  • Simplification of the catalog Dockerfile to only handle TALM-specific naming fixes.
  • Migration from catalog.yaml to catalog.json throughout the codebase.
  • Addition of ImageDigestMirrorSet (IDMS) configuration for catalog rendering.
  • Enabling hermetic builds (hermetic: true) in the FBC pipeline.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rauhersu
Copy link
Contributor Author

/assign @fontivan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants