Skip to content

MGMT-21823: Review and create page styling not applied #3216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

MGMT-21823: Review and create page styling not applied #3216

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions libs/ui-lib/lib/ocm/components/clusterConfiguration/review/ReviewCluster.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,12 @@
width: 100%;
}

.summary-expandable .pf-v6-c-expandable-section__toggle,
#summary-expandable > .pf-v6-c-expandable-section__toggle .pf-v6-c-button__text,
.review-expandable > .pf-v6-c-expandable-section__toggle {
color: initial;
text-align: left;
}

.summary-expandable
> .pf-v6-c-expandable-section__toggle
> .pf-v6-c-expandable-section__toggle-icon {
#summary-expandable > .pf-v6-c-expandable-section__toggle .pf-v6-c-button__icon {
visibility: hidden;
}
2 changes: 1 addition & 1 deletion libs/ui-lib/lib/ocm/components/clusterConfiguration/review/ReviewPreflightChecks.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ const ReviewPreflightChecks = ({ cluster }: { cluster: Cluster }) => {
<ExpandableSection
toggleContent={
<Grid>
<GridItem span={2} className="pf-v6-u-text-wrap">
<GridItem span={2} className="pf-v6-u-text-wrap pf-v6-u-text-align-start">
Preflight checks
</GridItem>
{!isChecksExpanded && <PreflightChecksDetailCollapsed cluster={cluster} />}
Expand Down
10 changes: 8 additions & 2 deletions libs/ui-lib/lib/ocm/components/clusterConfiguration/review/ReviewSummary.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import React from 'react';
import { ExpandableSection } from '@patternfly/react-core';
import {
DetailItem,
DetailList,
Expand Down Expand Up @@ -67,9 +68,14 @@ export const ReviewSummaryContent = ({ cluster }: { cluster: Cluster }) => {

const ReviewSummary = ({ cluster }: { cluster: Cluster }) => {
return (
<TableSummaryExpandable title={'Cluster summary'} id={'summary-expandable'}>
<ExpandableSection
toggleContent={'Cluster summary'}
id={'summary-expandable'}
isExpanded={true}
isIndented
>
<ReviewSummaryContent cluster={cluster} />
</TableSummaryExpandable>
</ExpandableSection>
);
};

Expand Down
4 changes: 2 additions & 2 deletions libs/ui-lib/lib/ocm/components/clusterConfiguration/review/TableSummaryExpandable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import React from 'react';
import { ExpandableSection } from '@patternfly/react-core';
import { ExpandableSection, Content } from '@patternfly/react-core';

export const TableSummaryExpandable = ({
title,
Expand All @@ -13,7 +13,7 @@ export const TableSummaryExpandable = ({
const [isExpanded, setExpanded] = React.useState(true);
return (
<ExpandableSection
toggleContent={<b>{title}</b>}
toggleContent={<Content className="pf-v6-u-font-weight-bold">{title}</Content>}
isExpanded={isExpanded}
onToggle={() => setExpanded(!isExpanded)}
isIndented
Expand Down
Loading