-
Notifications
You must be signed in to change notification settings - Fork 58
NO-ISSUE: Edit OWNERS file #3172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@jgyselov: This pull request explicitly references no jira issue. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Skipping CI for Draft Pull Request. |
WalkthroughAdds a single reviewer entry (LiorSoffer) to the reviewers list in the OWNERS file. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The following users are mentioned in OWNERS file(s) but are untrusted for the following reasons. One way to make the user trusted is to add them as members of the openshift-assisted org. You can then trigger verification by writing
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
OWNERS (1)
9-18: Nit: consider keeping reviewers alphabetizedFor maintainability, consider alphabetizing the reviewers list in a follow-up PR. No blocker since the list wasn’t previously sorted either.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
OWNERS(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
- GitHub Check: unit-tests
- GitHub Check: format
- GitHub Check: tests
- GitHub Check: translation-files
- GitHub Check: lint
- GitHub Check: circular-deps
🔇 Additional comments (1)
OWNERS (1)
18-18: Addition LGTM — verify org membership before mergeUser exists and OWNERS entry present (OWNERS: line 18). Membership check returned HTTP 403 (Resource not accessible by integration); repo permission for LiorSoffer is "read". Confirm the GitHub handle is correct and that LiorSoffer is an openshift-assisted org member (required for Prow OWNER approvals).
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ammont82, jgyselov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Summary by CodeRabbit