ACM-21694: Static IP form for BMC host discovery flow #3044

jgyselov · 2025-07-14T08:53:29Z

https://issues.redhat.com/browse/ACM-21694

Stolostron/console PR: stolostron/console#5075

openshift-ci-robot · 2025-07-14T08:53:32Z

@jgyselov: This pull request references ACM-21694 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.20.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2025-07-14T08:53:33Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

coderabbitai · 2025-07-14T08:53:34Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

openshift-ci-robot · 2025-07-14T08:53:51Z

@jgyselov: This pull request references ACM-21694 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.20.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2025-10-07T12:20:29Z

@jgyselov: This pull request references ACM-21694 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.21.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2025-10-07T13:55:11Z

@jgyselov: This pull request references ACM-21694 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.21.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2025-10-07T13:55:16Z

@jgyselov: This pull request references ACM-21694 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.21.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2025-10-07T14:48:15Z

@jgyselov: This pull request references ACM-21694 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.21.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2025-10-08T08:31:31Z

@jgyselov: This pull request references ACM-21694 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.21.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2025-10-08T08:31:37Z

@jgyselov: This pull request references ACM-21694 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.21.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2025-10-08T08:31:52Z

@jgyselov: This pull request references ACM-21694 which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2025-10-08T08:44:40Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jgyselov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [jgyselov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2025-10-08T10:04:29Z

@jgyselov: This pull request references ACM-21694 which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

rawagner · 2025-10-08T12:22:32Z

libs/ui-lib/lib/cim/components/Agent/BMCForm/BMCForm.tsx

+  const addNmState =
+    infraEnv.metadata?.labels && infraEnv.metadata?.labels['networkType'] === 'static';
+
+  const { initValues, validationSchema } = React.useMemo(() => {
+    const initValues = getInitValues(bmh, nmState, secret, isEdit, addNmState);
+    const validationSchema = getValidationSchema(usedHostnames, initValues.hostname, t);
+    return { initValues, validationSchema };
+  }, [bmh, nmState, secret, isEdit, addNmState, usedHostnames, t]);


we dont have to memoize values & schema

Suggested change

const addNmState =

infraEnv.metadata?.labels && infraEnv.metadata?.labels['networkType'] === 'static';

const { initValues, validationSchema } = React.useMemo(() => {

const initValues = getInitValues(bmh, nmState, secret, isEdit, addNmState);

const validationSchema = getValidationSchema(usedHostnames, initValues.hostname, t);

return { initValues, validationSchema };

}, [bmh, nmState, secret, isEdit, addNmState, usedHostnames, t]);

const addNmState = infraEnv.metadata?.labels?.networkType === 'static';

const initValues = getInitValues(bmh, nmState, secret, isEdit, addNmState);

const validationSchema = getValidationSchema(usedHostnames, initValues.hostname, t);

rawagner · 2025-10-08T12:27:41Z

libs/ui-lib/lib/cim/components/Agent/BMCForm/MacMapping.tsx

+            <GridItem span={5}>
+              <Text component={TextVariants.small}>MAC address</Text>
+            </GridItem>
+            <GridItem span={5}>
+              <Text component={TextVariants.small}>NIC</Text>
+            </GridItem>


should we i18n these texts ?

rawagner · 2025-10-08T12:37:09Z

libs/ui-lib/lib/common/components/staticIP/MachineNetworkField.tsx

+        <PopoverIcon noVerticalAlign bodyContent="The range of IP addresses of the hosts." />
+      }
+      label="Machine network"


openshift-merge-robot · 2025-10-10T22:33:43Z

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 14, 2025

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 14, 2025

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 14, 2025

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 14, 2025

openshift-ci bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jul 14, 2025

jgyselov force-pushed the bmc_static_ip branch from abc637d to 6b28255 Compare July 14, 2025 08:56

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 14, 2025

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 23, 2025

jgyselov added 3 commits October 2, 2025 11:03

BMC add hosts file restructure

3ac6f99

Static IP form for BMC host discovery

820e407

Rework setting initial BMC values

7006256

jgyselov force-pushed the bmc_static_ip branch from 6b28255 to 5ee0e5c Compare October 7, 2025 14:51

jgyselov changed the base branch from master to releases/v2.16-cim October 8, 2025 08:31

jgyselov marked this pull request as ready for review October 8, 2025 08:31

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 8, 2025

openshift-ci bot requested review from asmasarw and batzionb October 8, 2025 08:32

jgyselov added 2 commits October 8, 2025 10:44

BMC static IP translations

1b3c2d8

Disabling fields in OCM readonly

66643e9

jgyselov force-pushed the bmc_static_ip branch from 9242c91 to 66643e9 Compare October 8, 2025 08:44

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 8, 2025

jgyselov added this to the v2.16-cim milestone Oct 8, 2025

jgyselov mentioned this pull request Oct 8, 2025

ACM-21694: Static IP form for BMC host discovery flow stolostron/console#5075

Open

19 tasks

rawagner reviewed Oct 8, 2025

View reviewed changes

jgyselov added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 10, 2025

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 10, 2025

ACM-21694: Static IP form for BMC host discovery flow #3044

Are you sure you want to change the base?

ACM-21694: Static IP form for BMC host discovery flow #3044

Uh oh!

Conversation

jgyselov commented Jul 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Jul 14, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

TODO:

Uh oh!

openshift-ci bot commented Jul 14, 2025

Uh oh!

coderabbitai bot commented Jul 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

openshift-ci-robot commented Jul 14, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

TODO:

Uh oh!

openshift-ci-robot commented Oct 7, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

TODO:

Uh oh!

openshift-ci-robot commented Oct 7, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

TODO:

Uh oh!

openshift-ci-robot commented Oct 7, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

TODO:

Uh oh!

openshift-ci-robot commented Oct 7, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

TODO:

Uh oh!

openshift-ci-robot commented Oct 8, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

TODO:

Uh oh!

openshift-ci-robot commented Oct 8, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Oct 8, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci bot commented Oct 8, 2025

Uh oh!

openshift-ci-robot commented Oct 8, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rawagner Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

rawagner Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

rawagner Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

openshift-merge-robot commented Oct 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jgyselov commented Jul 14, 2025 •

edited

Loading

openshift-ci-robot commented Jul 14, 2025 •

edited by openshift-ci bot

Loading

coderabbitai bot commented Jul 14, 2025 •

edited

Loading

openshift-ci-robot commented Jul 14, 2025 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Oct 7, 2025 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Oct 7, 2025 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Oct 7, 2025 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Oct 7, 2025 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Oct 8, 2025 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Oct 8, 2025 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Oct 8, 2025 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Oct 8, 2025 •

edited by openshift-ci bot

Loading