Use Subclass method for Versiona and Channel type which is understood…

[jayeshathila]

… by security plugin

Description

Use Subclass method for Versiona and Channel type which is understood…

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

• [Y ] New functionality includes testing.
• [Y] New functionality has been documented.
• [Y] Commits are signed per the DCO using --signoff.
• [ Y] Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Issue - #609

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.80%. Comparing base (9cb092f) to head (4c4df03).
⚠️ Report is 41 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main     #845      +/-   ##
============================================
- Coverage     70.88%   69.80%   -1.08%     
- Complexity      421      491      +70     
============================================
  Files            49       54       +5     
  Lines          3125     3520     +395     
  Branches        194      228      +34     
============================================
+ Hits           2215     2457     +242     
- Misses          785      911     +126     
- Partials        125      152      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[cwperks]

Thank you for fixing this @jayeshathila ! With this, the security repo can finally remove the getInnerChannel reflection code used in its transport interceptors which was introduced to adapt to the initial wrapped handler change from PA.

FYI PA should consider running integ tests with the security plugin installed and enabled.

You can find the most recent example of setup on SRW repo with the set of PRs from here: https://github.com/opensearch-project/search-relevance/pulls?q=is%3Apr+author%3Acwperks+is%3Aclosed

[kumjiten]

+1, on adding integration tests.

[kumjiten]

remove this also https://github.com/opensearch-project/performance-analyzer/pull/845/files#diff-0254c68464c0f2bbe237f49361e855a4da0f1c62d08e7d9e8ca6374f991baf2aR159

 // remove this function without changing the security plugin.
    public TransportChannel getInnerChannel() {
        return this.original;
    }

[jayeshathila]

remove this also https://github.com/opensearch-project/performance-analyzer/pull/845/files#diff-0254c68464c0f2bbe237f49361e855a4da0f1c62d08e7d9e8ca6374f991baf2aR159

 // remove this function without changing the security plugin.
    public TransportChannel getInnerChannel() {
        return this.original;
    }

Done.

[jayeshathila]

Thank you for fixing this @jayeshathila ! With this, the security repo can finally remove the getInnerChannel reflection code used in its transport interceptors which was introduced to adapt to the initial wrapped handler change from PA.

FYI PA should consider running integ tests with the security plugin installed and enabled.

You can find the most recent example of setup on SRW repo with the set of PRs from here: https://github.com/opensearch-project/search-relevance/pulls?q=is%3Apr+author%3Acwperks+is%3Aclosed

For Integ Test addition, we can take it up as followup.
I will need your re-approval as I made some minor changes to address @kumjiten comment.