refresh ml key #3934
Open
refresh ml key #3934
+319
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jngz-es
requested review from
b4sjoo,
dhrubo-os,
mingshl,
model-collapse,
rbhavna,
ylwu-amzn,
zane-neo,
Zhangxunmt,
austintlee,
HenryL27 and
xinyual
as code owners
|
I am adding more IT for cover the fix. |
jngz-es
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
jngz-es
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
jngz-es
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
jngz-es
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
jngz-es
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
jngz-es
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
jngz-es
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
jngz-es
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
jngz-es
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
jngz-es
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
jngz-es
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
jngz-es
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
jngz-es
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
jngz-es
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
jngz-es
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
jngz-es
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
jngz-es
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
jngz-es
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
jngz-es
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
jngz-es
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
jngz-es
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
jngz-es
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
jngz-es
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
jngz-es
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
jngz-es
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
jngz-es
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
Signed-off-by: Jing Zhang <[email protected]>
jngz-es
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
jngz-es
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
jngz-es
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
jngz-es
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
jngz-es
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
jngz-es
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
jngz-es
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
jngz-es
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
jngz-es
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
jngz-es
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
Zhangxunmt
reviewed
Jun 27, 2025
| // Refresh the key from the config index. | ||
| public void refreshMasterKey(ActionListener<Boolean> listener) { | ||
| try { | ||
| // Currently, we only handle no tenant case. |
There was a problem hiding this comment.
Is that because the tenantId is not available when running the syncUp on each node? otherwise just fill in the tenantId in the initMasterKeyFromIndex(tenantId) it should refresh the masterKey.
Zhangxunmt
approved these changes
Jun 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refresh ML key from the index to keep the consistence between memory and index which is under a flag. In some edge cases, we could get divergence between the key cached in memory and in the system index. Currently we only have to restart the node to re-fetch the key from the index to mitigate the issue. With the fix, we can only use a flag to control.
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.