-
Notifications
You must be signed in to change notification settings - Fork 163
remove ml config index creation from cron job #3850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3850 +/- ##
=========================================
Coverage 80.01% 80.01%
+ Complexity 7730 7724 -6
=========================================
Files 678 678
Lines 34198 34168 -30
Branches 3795 3794 -1
=========================================
- Hits 27364 27340 -24
+ Misses 5143 5140 -3
+ Partials 1691 1688 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Rebase with main branch ? |
done |
I have some concerns about removing the ML config index creation from the cron job without having benchmark data on connector initialization times (which includes index creation requests, saving connector information, and key fetching). Having this data would help us better understand the potential impacts and make a more informed decision. Would it be possible to gather this information first? Specially when we have a static timeout, if we can make it listener based, then I don't have concern with this change. |
Signed-off-by: Jing Zhang <[email protected]>
fdfd1fa
to
44863b6
Compare
Description
Related Issues
#3806
Check List
--signoff
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.