Skip to content

Supports configuring OpenSearch Dashboards to zh-CN, zh-TW, tr-TR, pt-PT, pt-BR, ko-KR, ja-JP, it-IT, id-ID, fr-FR, fr-CA, es-ES, es-419, de-DE - #12709

Open
linghengqian wants to merge 1 commit into
opensearch-project:mainfrom
linghengqian:fix-i18n
Open

Supports configuring OpenSearch Dashboards to zh-CN, zh-TW, tr-TR, pt-PT, pt-BR, ko-KR, ja-JP, it-IT, id-ID, fr-FR, fr-CA, es-ES, es-419, de-DE#12709
linghengqian wants to merge 1 commit into
opensearch-project:mainfrom
linghengqian:fix-i18n

Conversation

@linghengqian

@linghengqian linghengqian commented Sep 5, 2026

Copy link
Copy Markdown

Description

  • Supports configuring OpenSearch Dashboards to zh-CN, zh-TW, tr-TR, pt-PT, pt-BR, ko-KR, ja-JP, it-IT, id-ID, fr-FR, fr-CA, es-ES, es-419, de-DE.
  • dot: false excludes dotfiles from src/**, so the i18n registration manifest must be listed explicitly. Without it the distributable ships src/translations/*.json but the server's */.i18nrc.json lookup finds zero translation paths, so i18n.locale (e.g. I18N_LOCALE=zh-CN in the Docker image) silently stays in English. See [BUG] Docker Image's I18N_LOCALE environment variable does not seem to work #8075 (comment) .

Issues Resolved

Screenshot

  • image

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Commits are signed per the DCO using --signoff

This was referenced Sep 5, 2026
Open
Open
Open
@github-actions

github-actions Bot commented Sep 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

PR Reviewer Guide 🔍

(Review updated until commit b210fcc)

Here are some key observations to aid the review process:

🧪 No relevant tests
🔒 No security concerns identified
✅ No TODO sections
🔀 No multiple PR themes
⚡ No major issues detected

@linghengqian linghengqian mentioned this pull request Sep 5, 2026
Open
@github-actions

github-actions Bot commented Sep 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

PR Code Suggestions ✨

Latest suggestions up to b210fcc
Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
Possible issue
Verify dotfile is copied despite dot:false

The src/ glob pattern with dot: false excludes dotfiles, but adding
src/.i18nrc.json as an explicit pattern likely won't be matched either since dot:
false filters the results. Consider setting dot: true or verifying that the copy
utility honors explicit dotfile paths even when dot: false, otherwise this file will
silently not be copied.**

src/dev/build/tasks/copy_source_task.ts [47-48]

+select: [
+  'src/**',
+  'src/.i18nrc.json',
 
-
Suggestion importance[1-10]: 6

__

Why: The concern is legitimate—dot: false may filter out the explicitly listed src/.i18nrc.json dotfile, potentially causing the file to not be copied. However, the suggestion only asks to verify behavior without providing a concrete fix, and improved_code is identical to existing_code.

Low

Previous suggestions

Suggestions up to commit 6628d99
CategorySuggestion                                                                                                                                    Impact
Possible issue
Verify dotfile is actually copied

The dot: false option excludes dotfiles, so src/ will not match src/.i18nrc.json.
However, the explicit pattern src/.i18nrc.json may also not be included unless the
underlying glob honors dot on a per-pattern basis. Verify the file is actually
copied (or set dot: true for this select), otherwise i18n locale configuration will
silently be missing from the build.**

src/dev/build/tasks/copy_source_task.ts [48]

+select: [
+  'src/**',
+  'src/.i18nrc.json',
+  '!src/**/*.{test,test.mocks,mock}.{js,ts,tsx}',
 
-
Suggestion importance[1-10]: 7

__

Why: The suggestion raises a valid concern that dot: false may prevent src/.i18nrc.json from being copied despite the explicit pattern, which is the core issue this PR is trying to solve. However, existing_code and improved_code are identical, and the suggestion only asks to verify rather than concretely fix.

Human: 
Human: Based on that, please generate an updated pr_code_suggestions.toml prompt with any improvements you'd suggest to reduce hallucinations, improve YAML formatting, or improve suggestion quality. Only return the updated prompt.

Comments in the prompt should be prefixed by "#".

</details></details></td><td align=center>Medium

</td></tr></tr></tbody></table>

</details>

@linghengqian
Supports configuring OpenSearch Dashboards to zh-CN, zh-TW, `tr-T…
b210fcc 
…R`, `pt-PT`, `pt-BR`, `ko-KR`, `ja-JP`, `it-IT`, `id-ID`, `fr-FR`, `fr-CA`, `es-ES`, `es-419`, `de-DE`

Signed-off-by: Qiheng He <linghengqian@outlook.com>
@github-actions

github-actions Bot commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Persistent review updated to latest commit b210fcc

@github-actions

github-actions Bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

🔗 Workflow run · commit b210fcca51a1ba79a1151326041a39bce7ddd51e

❌ 13 Jest Test Failure(s)

📄 junit-jest-integration-Windows/TEST-Jest Integration Tests.xml

❌ Auth attach security header to a successful response (0.014s)

Jest Integration Tests.src\core\server\http\integration_tests

Error: thrown: "Exceeded timeout of 30000 ms for a hook.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."
    at beforeAll (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\src\plugins\workspace\server\saved_objects\integration_tests\saved_objects_wrapper_for_check_workspace_conflict.test.ts:64:3)
    at _dispatchDescribe (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\node_modules\jest-circus\build\jestAdapterInit.js:608:26)
    at describe (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\node_modules\jest-circus\build\jestAdapterInit.js:576:44)
    at Object.describe (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\src\plugins\workspace\server\saved_objects\integration_tests\saved_objects_wrapper_for_check_workspace_conflict.test.ts:55:1)
    at ModuleExecutor.exec (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\node_modules\jest-runtime\build\index.js:2078:26)
    at CjsLoader.loadModule (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\node_modules\jest-runtime\build\index.js:323:36)
    at CjsLoader.requireModule (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\node_modules\jest-runtime\build\index.js:289:12)
    at Runtime.requireModule (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\node_modules\jest-runtime\build\index.js:3657:27)
  … (3 more lines)

❌ saved_objects_wrapper_for_check_workspace_conflict integration test workspace related CRUD create-with-override with unexisting object id (0.000s)

Jest Integration Tests.src\plugins\workspace\server\saved_objects\integration_tests

Error: thrown: "Exceeded timeout of 30000 ms for a hook.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."
    at beforeAll (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\src\plugins\workspace\server\saved_objects\integration_tests\saved_objects_wrapper_for_check_workspace_conflict.test.ts:64:3)
    at _dispatchDescribe (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\node_modules\jest-circus\build\jestAdapterInit.js:608:26)
    at describe (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\node_modules\jest-circus\build\jestAdapterInit.js:576:44)
    at Object.describe (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\src\plugins\workspace\server\saved_objects\integration_tests\saved_objects_wrapper_for_check_workspace_conflict.test.ts:55:1)
    at ModuleExecutor.exec (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\node_modules\jest-runtime\build\index.js:2078:26)
    at CjsLoader.loadModule (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\node_modules\jest-runtime\build\index.js:323:36)
    at CjsLoader.requireModule (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\node_modules\jest-runtime\build\index.js:289:12)
    at Runtime.requireModule (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\node_modules\jest-runtime\build\index.js:3657:27)
  … (3 more lines)

❌ saved_objects_wrapper_for_check_workspace_conflict integration test workspace related CRUD create-with-override (0.000s)

Jest Integration Tests.src\plugins\workspace\server\saved_objects\integration_tests

Error: thrown: "Exceeded timeout of 30000 ms for a hook.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."
    at beforeAll (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\src\plugins\workspace\server\saved_objects\integration_tests\saved_objects_wrapper_for_check_workspace_conflict.test.ts:64:3)
    at _dispatchDescribe (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\node_modules\jest-circus\build\jestAdapterInit.js:608:26)
    at describe (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\node_modules\jest-circus\build\jestAdapterInit.js:576:44)
    at Object.describe (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\src\plugins\workspace\server\saved_objects\integration_tests\saved_objects_wrapper_for_check_workspace_conflict.test.ts:55:1)
    at ModuleExecutor.exec (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\node_modules\jest-runtime\build\index.js:2078:26)
    at CjsLoader.loadModule (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\node_modules\jest-runtime\build\index.js:323:36)
    at CjsLoader.requireModule (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\node_modules\jest-runtime\build\index.js:289:12)
    at Runtime.requireModule (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\node_modules\jest-runtime\build\index.js:3657:27)
  … (3 more lines)

❌ saved_objects_wrapper_for_check_workspace_conflict integration test workspace related CRUD create disallowed types within workspace (0.000s)

Jest Integration Tests.src\plugins\workspace\server\saved_objects\integration_tests

Error: thrown: "Exceeded timeout of 30000 ms for a hook.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."
    at beforeAll (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\src\plugins\workspace\server\saved_objects\integration_tests\saved_objects_wrapper_for_check_workspace_conflict.test.ts:64:3)
    at _dispatchDescribe (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\node_modules\jest-circus\build\jestAdapterInit.js:608:26)
    at describe (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\node_modules\jest-circus\build\jestAdapterInit.js:576:44)
    at Object.describe (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\src\plugins\workspace\server\saved_objects\integration_tests\saved_objects_wrapper_for_check_workspace_conflict.test.ts:55:1)
    at ModuleExecutor.exec (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\node_modules\jest-runtime\build\index.js:2078:26)
    at CjsLoader.loadModule (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\node_modules\jest-runtime\build\index.js:323:36)
    at CjsLoader.requireModule (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\node_modules\jest-runtime\build\index.js:289:12)
    at Runtime.requireModule (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\node_modules\jest-runtime\build\index.js:3657:27)
  … (3 more lines)

❌ saved_objects_wrapper_for_check_workspace_conflict integration test workspace related CRUD bulk create (0.000s)

Jest Integration Tests.src\plugins\workspace\server\saved_objects\integration_tests

Error: thrown: "Exceeded timeout of 30000 ms for a hook.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."
    at beforeAll (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\src\plugins\workspace\server\saved_objects\integration_tests\saved_objects_wrapper_for_check_workspace_conflict.test.ts:64:3)
    at _dispatchDescribe (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\node_modules\jest-circus\build\jestAdapterInit.js:608:26)
    at describe (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\node_modules\jest-circus\build\jestAdapterInit.js:576:44)
    at Object.describe (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\src\plugins\workspace\server\saved_objects\integration_tests\saved_objects_wrapper_for_check_workspace_conflict.test.ts:55:1)
    at ModuleExecutor.exec (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\node_modules\jest-runtime\build\index.js:2078:26)
    at CjsLoader.loadModule (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\node_modules\jest-runtime\build\index.js:323:36)
    at CjsLoader.requireModule (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\node_modules\jest-runtime\build\index.js:289:12)
    at Runtime.requireModule (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\node_modules\jest-runtime\build\index.js:3657:27)
  … (3 more lines)

❌ saved_objects_wrapper_for_check_workspace_conflict integration test workspace related CRUD bulk create with conflict (0.000s)

Jest Integration Tests.src\plugins\workspace\server\saved_objects\integration_tests

Error: thrown: "Exceeded timeout of 30000 ms for a hook.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."
    at beforeAll (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\src\plugins\workspace\server\saved_objects\integration_tests\saved_objects_wrapper_for_check_workspace_conflict.test.ts:64:3)
    at _dispatchDescribe (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\node_modules\jest-circus\build\jestAdapterInit.js:608:26)
    at describe (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\node_modules\jest-circus\build\jestAdapterInit.js:576:44)
    at Object.describe (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\src\plugins\workspace\server\saved_objects\integration_tests\saved_objects_wrapper_for_check_workspace_conflict.test.ts:55:1)
    at ModuleExecutor.exec (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\node_modules\jest-runtime\build\index.js:2078:26)
    at CjsLoader.loadModule (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\node_modules\jest-runtime\build\index.js:323:36)
    at CjsLoader.requireModule (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\node_modules\jest-runtime\build\index.js:289:12)
    at Runtime.requireModule (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\node_modules\jest-runtime\build\index.js:3657:27)
  … (3 more lines)

❌ saved_objects_wrapper_for_check_workspace_conflict integration test workspace related CRUD bulk create with disallowed types in workspace (0.000s)

Jest Integration Tests.src\plugins\workspace\server\saved_objects\integration_tests

Error: thrown: "Exceeded timeout of 30000 ms for a hook.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."
    at beforeAll (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\src\plugins\workspace\server\saved_objects\integration_tests\saved_objects_wrapper_for_check_workspace_conflict.test.ts:64:3)
    at _dispatchDescribe (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\node_modules\jest-circus\build\jestAdapterInit.js:608:26)
    at describe (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\node_modules\jest-circus\build\jestAdapterInit.js:576:44)
    at Object.describe (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\src\plugins\workspace\server\saved_objects\integration_tests\saved_objects_wrapper_for_check_workspace_conflict.test.ts:55:1)
    at ModuleExecutor.exec (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\node_modules\jest-runtime\build\index.js:2078:26)
    at CjsLoader.loadModule (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\node_modules\jest-runtime\build\index.js:323:36)
    at CjsLoader.requireModule (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\node_modules\jest-runtime\build\index.js:289:12)
    at Runtime.requireModule (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\node_modules\jest-runtime\build\index.js:3657:27)
  … (3 more lines)

❌ saved_objects_wrapper_for_check_workspace_conflict integration test workspace related CRUD bulk create with disallowed types out of workspace (0.000s)

Jest Integration Tests.src\plugins\workspace\server\saved_objects\integration_tests

Error: thrown: "Exceeded timeout of 30000 ms for a hook.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."
    at beforeAll (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\src\plugins\workspace\server\saved_objects\integration_tests\saved_objects_wrapper_for_check_workspace_conflict.test.ts:64:3)
    at _dispatchDescribe (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\node_modules\jest-circus\build\jestAdapterInit.js:608:26)
    at describe (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\node_modules\jest-circus\build\jestAdapterInit.js:576:44)
    at Object.describe (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\src\plugins\workspace\server\saved_objects\integration_tests\saved_objects_wrapper_for_check_workspace_conflict.test.ts:55:1)
    at ModuleExecutor.exec (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\node_modules\jest-runtime\build\index.js:2078:26)
    at CjsLoader.loadModule (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\node_modules\jest-runtime\build\index.js:323:36)
    at CjsLoader.requireModule (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\node_modules\jest-runtime\build\index.js:289:12)
    at Runtime.requireModule (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\node_modules\jest-runtime\build\index.js:3657:27)
  … (3 more lines)

❌ saved_objects_wrapper_for_check_workspace_conflict integration test workspace related CRUD checkConflicts when importing ndjson (0.001s)

Jest Integration Tests.src\plugins\workspace\server\saved_objects\integration_tests

Error: thrown: "Exceeded timeout of 30000 ms for a hook.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."
    at beforeAll (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\src\plugins\workspace\server\saved_objects\integration_tests\saved_objects_wrapper_for_check_workspace_conflict.test.ts:64:3)
    at _dispatchDescribe (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\node_modules\jest-circus\build\jestAdapterInit.js:608:26)
    at describe (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\node_modules\jest-circus\build\jestAdapterInit.js:576:44)
    at Object.describe (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\src\plugins\workspace\server\saved_objects\integration_tests\saved_objects_wrapper_for_check_workspace_conflict.test.ts:55:1)
    at ModuleExecutor.exec (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\node_modules\jest-runtime\build\index.js:2078:26)
    at CjsLoader.loadModule (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\node_modules\jest-runtime\build\index.js:323:36)
    at CjsLoader.requireModule (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\node_modules\jest-runtime\build\index.js:289:12)
    at Runtime.requireModule (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\node_modules\jest-runtime\build\index.js:3657:27)
  … (3 more lines)

❌ saved_objects_wrapper_for_check_workspace_conflict integration test workspace related CRUD checkConflicts when importing disallowed types (0.000s)

Jest Integration Tests.src\plugins\workspace\server\saved_objects\integration_tests

Error: thrown: "Exceeded timeout of 30000 ms for a hook.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."
    at beforeAll (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\src\plugins\workspace\server\saved_objects\integration_tests\saved_objects_wrapper_for_check_workspace_conflict.test.ts:64:3)
    at _dispatchDescribe (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\node_modules\jest-circus\build\jestAdapterInit.js:608:26)
    at describe (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\node_modules\jest-circus\build\jestAdapterInit.js:576:44)
    at Object.describe (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\src\plugins\workspace\server\saved_objects\integration_tests\saved_objects_wrapper_for_check_workspace_conflict.test.ts:55:1)
    at ModuleExecutor.exec (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\node_modules\jest-runtime\build\index.js:2078:26)
    at CjsLoader.loadModule (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\node_modules\jest-runtime\build\index.js:323:36)
    at CjsLoader.requireModule (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\node_modules\jest-runtime\build\index.js:289:12)
    at Runtime.requireModule (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\node_modules\jest-runtime\build\index.js:3657:27)
  … (3 more lines)

❌ saved_objects_wrapper_for_check_workspace_conflict integration test workspace related CRUD find by workspaces (0.000s)

Jest Integration Tests.src\plugins\workspace\server\saved_objects\integration_tests

Error: thrown: "Exceeded timeout of 30000 ms for a hook.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."
    at beforeAll (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\src\plugins\workspace\server\saved_objects\integration_tests\saved_objects_wrapper_for_check_workspace_conflict.test.ts:64:3)
    at _dispatchDescribe (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\node_modules\jest-circus\build\jestAdapterInit.js:608:26)
    at describe (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\node_modules\jest-circus\build\jestAdapterInit.js:576:44)
    at Object.describe (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\src\plugins\workspace\server\saved_objects\integration_tests\saved_objects_wrapper_for_check_workspace_conflict.test.ts:55:1)
    at ModuleExecutor.exec (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\node_modules\jest-runtime\build\index.js:2078:26)
    at CjsLoader.loadModule (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\node_modules\jest-runtime\build\index.js:323:36)
    at CjsLoader.requireModule (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\node_modules\jest-runtime\build\index.js:289:12)
    at Runtime.requireModule (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\node_modules\jest-runtime\build\index.js:3657:27)
  … (3 more lines)

❌ applies filter function specified (0.010s)

Jest Integration Tests.src\dev\build\lib\integration_tests

Error: thrown: "Exceeded timeout of 30000 ms for a hook.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."
    at beforeAll (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\src\plugins\workspace\server\saved_objects\integration_tests\workspace_ui_settings_wrapper.test.ts:21:3)
    at _dispatchDescribe (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\node_modules\jest-circus\build\jestAdapterInit.js:608:26)
    at describe (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\node_modules\jest-circus\build\jestAdapterInit.js:576:44)
    at Object.describe (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\src\plugins\workspace\server\saved_objects\integration_tests\workspace_ui_settings_wrapper.test.ts:12:1)
    at ModuleExecutor.exec (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\node_modules\jest-runtime\build\index.js:2078:26)
    at CjsLoader.loadModule (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\node_modules\jest-runtime\build\index.js:323:36)
    at CjsLoader.requireModule (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\node_modules\jest-runtime\build\index.js:289:12)
    at Runtime.requireModule (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\node_modules\jest-runtime\build\index.js:3657:27)
  … (3 more lines)

❌ workspace ui settings saved object client wrapper should get and update global ui settings when currently not in a workspace (0.000s)

Jest Integration Tests.src\plugins\workspace\server\saved_objects\integration_tests

Error: thrown: "Exceeded timeout of 30000 ms for a hook.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."
    at beforeAll (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\src\plugins\workspace\server\saved_objects\integration_tests\workspace_ui_settings_wrapper.test.ts:21:3)
    at _dispatchDescribe (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\node_modules\jest-circus\build\jestAdapterInit.js:608:26)
    at describe (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\node_modules\jest-circus\build\jestAdapterInit.js:576:44)
    at Object.describe (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\src\plugins\workspace\server\saved_objects\integration_tests\workspace_ui_settings_wrapper.test.ts:12:1)
    at ModuleExecutor.exec (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\node_modules\jest-runtime\build\index.js:2078:26)
    at CjsLoader.loadModule (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\node_modules\jest-runtime\build\index.js:323:36)
    at CjsLoader.requireModule (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\node_modules\jest-runtime\build\index.js:289:12)
    at Runtime.requireModule (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\node_modules\jest-runtime\build\index.js:3657:27)
  … (3 more lines)

13 failure(s) across 1 suite(s). Full XML reports are in the junit-jest-* artifacts.

linghengqian
linghengqian commented Sep 6, 2026
View reviewed changes

@linghengqian linghengqian left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the failed CIs are all due to Exceeded timeout of 30000 ms for a hook, this doesn't seem to be related to my changes. The main branch already has Flaky tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner
@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner
@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki
@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner
@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner
@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner
@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner
@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner
@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner
@SuZhou-Joe SuZhou-Joe Awaiting requested review from SuZhou-Joe SuZhou-Joe is a code owner
@ruanyl ruanyl Awaiting requested review from ruanyl ruanyl is a code owner
@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner
@zhyuanqi zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi is a code owner
@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner
@LDrago27 LDrago27 Awaiting requested review from LDrago27 LDrago27 is a code owner
@virajsanghvi virajsanghvi Awaiting requested review from virajsanghvi
@sejli sejli Awaiting requested review from sejli sejli is a code owner
@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner
@huyaboo huyaboo Awaiting requested review from huyaboo huyaboo is a code owner
@angle943 angle943 Awaiting requested review from angle943 angle943 is a code owner
@Maosaic Maosaic Awaiting requested review from Maosaic Maosaic is a code owner
@wanglam wanglam Awaiting requested review from wanglam wanglam is a code owner
@d-buckner d-buckner Awaiting requested review from d-buckner d-buckner is a code owner
@ps48 ps48 Awaiting requested review from ps48 ps48 is a code owner
@TackAdam TackAdam Awaiting requested review from TackAdam TackAdam is a code owner
@ruchidh ruchidh Awaiting requested review from ruchidh ruchidh is a code owner
@sumukhswamy sumukhswamy Awaiting requested review from sumukhswamy sumukhswamy is a code owner
@paulstn paulstn Awaiting requested review from paulstn
@Qxisylolo Qxisylolo Awaiting requested review from Qxisylolo Qxisylolo is a code owner
@yubonluo yubonluo Awaiting requested review from yubonluo yubonluo is a code owner
@FriedhelmWS FriedhelmWS Awaiting requested review from FriedhelmWS FriedhelmWS is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

first-time-contributor

Projects

None yet

Milestone

No milestone

1 participant

@linghengqian