Skip to content

Move Configure and evaluate search row above search techniques in Search Workspace - #12647

Open
iprithv wants to merge 2 commits into
opensearch-project:mainfrom
iprithv:move-search-workspace-config-evaluate-row
Open

iprithv wants to merge 2 commits into
opensearch-project:mainfrom
iprithv:move-search-workspace-config-evaluate-row

Conversation

@iprithv

@iprithv iprithv commented Aug 26, 2026

Copy link
Copy Markdown

moves the Configure and evaluate search row (AI Search Flow and Search Relevance Workbench) above Try out different search techniques on the Search Workspace overview so those tiles sit above the fold. section render order is driven by order; this swaps config_evaluate_search and different_search_types.

resolves #12621

…rch Workspace

Signed-off-by: prithvi <prithvisivasankar@gmail.com>
@github-actions

github-actions Bot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

PR Reviewer Guide 🔍

(Review updated until commit 05aef51)

Here are some key observations to aid the review process:

🧪 PR contains tests
🔒 No security concerns identified
✅ No TODO sections
🔀 No multiple PR themes
⚡ No major issues detected

@zengyan-amazon

Copy link
Copy Markdown
Member

tagging @angle943 @ruanyl for triage

@ruanyl

ruanyl commented Aug 27, 2026

Copy link
Copy Markdown
Member

LGTM, approved

@epugh

epugh commented Aug 27, 2026

Copy link
Copy Markdown
Member

LGTM, approved

Woot! Let us know if there are any other ways to be a good member of the team... We have a bunch of other ideas to make Search Workspaces better.....

@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Persistent review updated to latest commit 05aef51

@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

🔗 Workflow run · commit 05aef5131e48b68c00c9d3ce248959b7c4457292

❌ 2 Jest Test Failure(s)

📄 junit-jest-integration-Windows/TEST-Jest Integration Tests.xml

❌ applies filter function specified (0.013s)

Jest Integration Tests.src\dev\build\lib\integration_tests

Error: thrown: "Exceeded timeout of 30000 ms for a hook.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."
    at beforeAll (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\src\plugins\workspace\server\saved_objects\integration_tests\workspace_ui_settings_wrapper.test.ts:21:3)
    at _dispatchDescribe (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\node_modules\jest-circus\build\jestAdapterInit.js:608:26)
    at describe (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\node_modules\jest-circus\build\jestAdapterInit.js:576:44)
    at Object.describe (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\src\plugins\workspace\server\saved_objects\integration_tests\workspace_ui_settings_wrapper.test.ts:12:1)
    at ModuleExecutor.exec (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\node_modules\jest-runtime\build\index.js:2078:26)
    at CjsLoader.loadModule (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\node_modules\jest-runtime\build\index.js:323:36)
    at CjsLoader.requireModule (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\node_modules\jest-runtime\build\index.js:289:12)
    at Runtime.requireModule (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\node_modules\jest-runtime\build\index.js:3657:27)
  … (3 more lines)

❌ workspace ui settings saved object client wrapper should get and update global ui settings when currently not in a workspace (0.000s)

Jest Integration Tests.src\plugins\workspace\server\saved_objects\integration_tests

Error: thrown: "Exceeded timeout of 30000 ms for a hook.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."
    at beforeAll (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\src\plugins\workspace\server\saved_objects\integration_tests\workspace_ui_settings_wrapper.test.ts:21:3)
    at _dispatchDescribe (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\node_modules\jest-circus\build\jestAdapterInit.js:608:26)
    at describe (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\node_modules\jest-circus\build\jestAdapterInit.js:576:44)
    at Object.describe (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\src\plugins\workspace\server\saved_objects\integration_tests\workspace_ui_settings_wrapper.test.ts:12:1)
    at ModuleExecutor.exec (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\node_modules\jest-runtime\build\index.js:2078:26)
    at CjsLoader.loadModule (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\node_modules\jest-runtime\build\index.js:323:36)
    at CjsLoader.requireModule (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\node_modules\jest-runtime\build\index.js:289:12)
    at Runtime.requireModule (D:\a\OpenSearch-Dashboards\OpenSearch-Dashboards\node_modules\jest-runtime\build\index.js:3657:27)
  … (3 more lines)

2 failure(s) across 1 suite(s). Full XML reports are in the junit-jest-* artifacts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move AI Search Flow and SRW row up to above the fold in Search Workspace layout

4 participants