Skip to content

fix: switch to ghcr.io for eic images; rm older jug_* images #496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 18, 2025

Conversation

wdconinc
Copy link
Contributor

@rynge rynge merged commit 0d370f3 into opensciencegrid:master Apr 18, 2025
1 check passed
@jasoncpatton
Copy link

Despite the test claiming it passed, it looks like using wildcards isn't supported for the GitHub container repo

Working on image: ghcr.io/eic/eic_xl:*-stable
  File "/github/workspace/./cvmfs-singularity-sync", line 165, in main
    tag_names = get_tags(namespace, repo_name, registry=registry, auth=doauth)
  File "/github/workspace/./cvmfs-singularity-sync", line 268, in get_tags
    for tag in hub.tags(username, repo):
               ~~~~~~~~^^^^^^^^^^^^^^^^
  File "/github/workspace/dockerhub.py", line 361, in _iter_requests_get_generator
    resp = self._do_requests_get(address, **kwargs)
  File "/github/workspace/dockerhub.py", line 337, in _do_requests_get
    return self._do_request('GET', address, **kwargs)
           ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/github/workspace/dockerhub.py", line 320, in _do_request
    resp.raise_for_status()
    ~~~~~~~~~~~~~~~~~~~~~^^
  File "/usr/local/lib/python3.13/site-packages/requests/models.py", line 1024, in raise_for_status
    raise HTTPError(http_error_msg, response=self)
requests.exceptions.HTTPError: 404 Client Error: Not Found for url: https://github.com/-/v2/packages/container/package/repositories%2Feic%2Feic_xl%2Ftags
b'Not Found'
{'Date': 'Fri, 18 Apr 2025 16:31:16 GMT', 'Content-Type': 'text/plain; charset=utf-8', 'Content-Length': '9', 'Vary': 'X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame,Accept-Encoding, Accept, X-Requested-With', 'Cache-Control': 'no-cache', 'Strict-Transport-Security': 'max-age=31536000; includeSubdomains; preload', 'X-Frame-Options': 'deny', 'X-Content-Type-Options': 'nosniff', 'X-XSS-Protection': '0', 'Referrer-Policy': 'origin-when-cross-origin, strict-origin-when-cross-origin', 'Content-Security-Policy': "default-src 'none'; base-uri 'self'; connect-src 'self'; form-action 'self'; img-src 'self' data:; script-src 'self'; style-src 'unsafe-inline'", 'Server': 'github.com', 'Set-Cookie': '_gh_sess=0qPKT2hk8vKdYjm1Ev7pBh9csrAUsdqdYoRkDGoRrW8uh1W32jy8mRwRt4%2BGq2tDVeBoiOoKy33PNM8Z7%2Fyx81R6gE7TOzb1KFYnRH%2B9gvDNuFS5jkftUTU4MwaFP96FoSKY8BYN2YHvFsg%2Fa9r34uqEZ9%2FDc0%2F198jI9qcn%2FciruHp57DFHzk49wo9sEVtB8LMd876nnjADqgYJlkAk9Q3Qj7ad1RaSTiEQCJfEtba02s0lN6IVSioVaxj1svhSeX3c8i2NU3u3FC3R%2BlKBcw%3D%3D--drbRRhks44UkVHSr--96IGE39IhuZDL5xifBkT4w%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax, _octo=GH1.1.72837135.1744993876; Path=/; Domain=github.com; Expires=Sat, 18 Apr 2026 16:31:16 GMT; Secure; SameSite=Lax, logged_in=no; Path=/; Domain=github.com; Expires=Sat, 18 Apr 2026 16:31:16 GMT; HttpOnly; Secure; SameSite=Lax', 'X-GitHub-Request-Id': '9441:11AC2F:7976DF:A58C15:68027E54'}
Failed to get tags for image: ghcr.io/eic/eic_xl
404 Client Error: Not Found for url: https://github.com/-/v2/packages/container/package/repositories%2Feic%2Feic_xl%2Ftags

(I suspect the sync code would have to switch to scrolling through e.g. https://github.com/eic/containers/pkgs/container/eic_xl/versions?filters%5Bversion_type%5D=tagged for ghcr.io URLs, seems... unpleasant)

@wdconinc
Copy link
Contributor Author

Do you want to revert this, or should we avoid the globs for now and add line by line whenever a new release? We can do that for a month while we adapt dockerhub.py to support get_tags on ghcr.io.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants