Conversation
Most status assertions under tests/ carry the response body or the response; test_entity.py mostly doesn't. Following the wider convention here so a CI failure shows why the request failed, and leaving the rest of the file alone.
by_id already fails on a bare ID, but with a TypeError rather than a readable assertion. This states what the test is for.
Contributor
|
As you wrote in the PR description, I don't quite know how you ended up wanting to tackle this issue, but if it's just an LLM looking for low-hanging fruit: We generally discourage low-effort contributions that are LLM-driven and contain very little to no human effort. If you're a human eager to join the community and contribute, that's something we absolutely welcome and I'm sure we can find some issues that would be fun and rewarding to work on! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #80.
Adds a test that walks the nested response across a
Familyedge: the root person, the fourFamilyentities naming them as a relative, and the person on the other side of each. Thezalafixture already has these ties, so no fixture changes.The general case has been covered since #686.
test_entity_nestednow walksPerson → Payment → Organizationonparteispenden. What was missing is theFamilycase this issue names, andzalais the only fixture with it.The
, res.texton the status assertion is a separate commit. Most assertions undertests/attach a message but this file mostly doesn't, so drop it if you'd rather keep the file consistent.