Skip to content
Open
Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
44 commits
Select commit Hold shift + click to select a range
0973eaa
Add RemoveUnusedParams recipe
iddeepak May 16, 2025
d93a14c
Apply suggestions from code review
timtebeek May 16, 2025
84d8671
Updated review comments
iddeepak May 16, 2025
6365a31
Updated review comments
iddeepak May 16, 2025
e718033
Update src/main/java/org/openrewrite/staticanalysis/RemoveUnusedParam…
iddeepak May 16, 2025
c735b6e
Updated review comments
iddeepak May 16, 2025
afff3de
Merge branch 'main' into feature/RemoveUnusedParams
timtebeek May 17, 2025
e6a633b
Update src/main/java/org/openrewrite/staticanalysis/RemoveUnusedParam…
iddeepak May 17, 2025
674a465
Update src/main/java/org/openrewrite/staticanalysis/RemoveUnusedParam…
iddeepak May 17, 2025
e656fa2
Updated review comments
iddeepak May 18, 2025
11ef2ac
Updated review comments
iddeepak May 18, 2025
f88dd77
Updated review comments
iddeepak May 18, 2025
6d989cc
Updated review comments
iddeepak May 19, 2025
80b57e8
Apply suggestions from code review
timtebeek May 19, 2025
95628c3
Updated review comments
iddeepak May 19, 2025
a6acdef
Added Test for nested inheritance override chain
iddeepak May 19, 2025
a4e7e3d
Update src/main/java/org/openrewrite/staticanalysis/RemoveUnusedParam…
iddeepak May 19, 2025
8e8953f
Update src/main/java/org/openrewrite/staticanalysis/RemoveUnusedParam…
iddeepak May 19, 2025
e03e540
Merge branch 'main' into feature/RemoveUnusedParams
timtebeek Jun 1, 2025
328984d
Merge branch 'openrewrite:main' into feature/RemoveUnusedParams
iddeepak Jun 6, 2025
c306682
Merge branch 'main' into feature/RemoveUnusedParams
timtebeek Jun 14, 2025
298ee1f
Show two cases missed with conflicts after removal
timtebeek Jun 14, 2025
9f689ab
Show another case missed: callers should be updated too
timtebeek Jun 14, 2025
28beff4
Remove unnecessary `final` to make intentional ones stand out
timtebeek Jun 14, 2025
0b77aa9
Inline `collectOverrideSignature` only used once
timtebeek Jun 14, 2025
c9c21ca
Move methods into named visitor for logical grouping
timtebeek Jun 14, 2025
d1bf138
Add missing braces
timtebeek Jun 14, 2025
25ece10
Use `reduce` in `collectUsedParameters`
timtebeek Jun 14, 2025
6bd0405
use ListUtils for referential comparison
iddeepak Jun 17, 2025
459d327
use SemanticallyEqual comparison
iddeepak Jun 17, 2025
12ccb6c
fix avoidDirectConflict and avoidInheritedConflict
iddeepak Jun 18, 2025
c527506
fix avoidDirectConflict
iddeepak Jun 18, 2025
dd23526
fix avoidInheritiedConflict
iddeepak Jun 18, 2025
03056a5
clean up
iddeepak Jun 18, 2025
f4a0ac0
clean up
iddeepak Jun 18, 2025
e1f414a
Update src/main/java/org/openrewrite/staticanalysis/RemoveUnusedParam…
iddeepak Jun 18, 2025
2cdeff6
fix cascadeRemove
iddeepak Jun 18, 2025
4f6b346
Update src/main/java/org/openrewrite/staticanalysis/RemoveUnusedParam…
iddeepak Jun 18, 2025
5e8d863
Merge branch 'main' into feature/RemoveUnusedParams
iddeepak Jun 18, 2025
ec388d6
fix build
iddeepak Jun 18, 2025
00817b3
Merge branch 'main' into feature/RemoveUnusedParams
timtebeek Jun 24, 2025
83157dc
Merge branch 'main' into feature/RemoveUnusedParams
timtebeek Jul 26, 2025
5be9333
Update src/main/java/org/openrewrite/staticanalysis/RemoveUnusedParam…
timtebeek Jul 27, 2025
1ee3249
Reduce warnings
timtebeek Aug 4, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
182 changes: 182 additions & 0 deletions src/main/java/org/openrewrite/staticanalysis/RemoveUnusedParams.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,182 @@
/*
* Copyright 2025 the original author or authors.
* <p>
* Licensed under the Moderne Source Available License (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
* <p>
* https://docs.moderne.io/licensing/moderne-source-available-license
* <p>
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.openrewrite.staticanalysis;

import org.openrewrite.ExecutionContext;
import org.openrewrite.Preconditions;
import org.openrewrite.Repeat;
import org.openrewrite.ScanningRecipe;
import org.openrewrite.TreeVisitor;
import org.openrewrite.java.JavaIsoVisitor;
import org.openrewrite.java.NoMissingTypes;
import org.openrewrite.java.tree.J;
import org.openrewrite.java.tree.Statement;

import java.time.Duration;
import java.util.ArrayDeque;
import java.util.ArrayList;
import java.util.Deque;
import java.util.HashSet;
import java.util.List;
import java.util.Set;
import java.util.stream.Collectors;

public class RemoveUnusedParams extends ScanningRecipe<RemoveUnusedParams.Accumulator> {

static class Accumulator {
final Set<String> OVERRIDE_SIGNATURES = new HashSet<>();
}

@Override
public String getDisplayName() {
return "Remove unused method parameters";
}

@Override
public String getDescription() {
return "Removes parameters from methods that are declared but never used in the method body.";
}

@Override
public Duration getEstimatedEffortPerOccurrence() {
return Duration.ofMinutes(5);
}

@Override
public Accumulator getInitialValue(ExecutionContext ctx) {
return new Accumulator();
}

private String buildSignature(J.MethodDeclaration m){
return m.getSimpleName() + "#" +
m.getMethodType().getParameterTypes()
.stream().map(p->p.toString())
.collect(Collectors.joining(","));
}

@Override
public TreeVisitor<?, ExecutionContext> getScanner(Accumulator acc) {
return new JavaIsoVisitor<ExecutionContext>() {
@Override
public J.MethodDeclaration visitMethodDeclaration(J.MethodDeclaration method, ExecutionContext ctx) {
J.MethodDeclaration m = super.visitMethodDeclaration(method, ctx);
for (J.Annotation ann : m.getLeadingAnnotations()) {
if ("Override".equals(ann.getSimpleName())) {
acc.OVERRIDE_SIGNATURES.add(buildSignature(m));
break;
}
}
return m;
}
};
}

@Override
public TreeVisitor<?, ExecutionContext> getVisitor(Accumulator acc) {
return Preconditions.check(new NoMissingTypes(),
Repeat.repeatUntilStable(new JavaIsoVisitor<ExecutionContext>() {

private boolean skipAnyExplicitOverride(J.MethodDeclaration m) {
return m.getMethodType() != null && m.getMethodType().isOverride();
}

private boolean skipIfOverriddenElsewhere(String signature) {
return acc.OVERRIDE_SIGNATURES.contains(signature);
}

@Override
public J.MethodDeclaration visitMethodDeclaration(J.MethodDeclaration method, ExecutionContext ctx) {
J.MethodDeclaration m = super.visitMethodDeclaration(method, ctx);

if (skipAnyExplicitOverride(m)) {
return m;
}

if (skipIfOverriddenElsewhere(buildSignature(m))) {
return m;
}

if (m.getBody() == null ||
m.hasModifier(J.Modifier.Type.Native) ||
!m.getLeadingAnnotations().isEmpty()) {
return m;
}

Set<String> params = m.getParameters().stream()
.filter(p -> p instanceof J.VariableDeclarations)
.flatMap(p -> ((J.VariableDeclarations) p).getVariables().stream())
.map(J.VariableDeclarations.NamedVariable::getSimpleName)
.collect(Collectors.toSet());

Set<String> used = new HashSet<>();
new JavaIsoVisitor<Set<String>>() {
Deque<Set<String>> shadowed = new ArrayDeque<>();

@Override
public J.Block visitBlock(J.Block block, Set<String> u) {
shadowed.push(new HashSet<>());
J.Block b = super.visitBlock(block, u);
shadowed.pop();
return b;
}

@Override
public J.VariableDeclarations visitVariableDeclarations(J.VariableDeclarations vars, Set<String> u) {
vars.getVariables().forEach(v -> shadowed.peek().add(v.getSimpleName()));
return super.visitVariableDeclarations(vars, u);
}

@Override
public J.Identifier visitIdentifier(J.Identifier ident, Set<String> u) {
for (Set<String> scope : shadowed) {
if (scope.contains(ident.getSimpleName())) {
return ident;
}
}
if (params.contains(ident.getSimpleName())) {
u.add(ident.getSimpleName());
}
return ident;
}
}.visit(m.getBody(), used);

List<Statement> newParams = new ArrayList<>();
for (Statement p : m.getParameters()) {
if (!(p instanceof J.VariableDeclarations)) {
newParams.add(p);
continue;
}
J.VariableDeclarations vd = (J.VariableDeclarations) p;
if (!vd.getLeadingAnnotations().isEmpty()) {
newParams.add(vd);
continue;
}
List<J.VariableDeclarations.NamedVariable> keep = vd.getVariables().stream()
.filter(v -> used.contains(v.getSimpleName()))
.collect(Collectors.toList());
if (!keep.isEmpty()) {
newParams.add(vd.withVariables(keep));
}
}

return newParams.equals(m.getParameters()) ?
m :
m.withParameters(newParams);
}
})
);
}
}
Loading