Move to HAProxy 3.2 LTS#29
Open
richturner wants to merge 3 commits into
Open
Conversation
8 tasks
Member
Author
|
Should look at using built in ACME functionality and removing use of certbot although that is providing AWS Route 53 wildcard cert generation which I doubt we can replace. |
|
There was a problem hiding this comment.
Pull request overview
This PR updates the container base image to HAProxy 3.2 (LTS) and adjusts the HAProxy config to eliminate a parsing warning around the optional MQTT rate-limiting ACL.
Changes:
- Bump Docker base image from
haproxy:2.8-alpinetohaproxy:3.2-alpine. - Update
haproxy.cfgMQTT rate-limit ACL to use a defaulted env expansion (${MQTT_RATE_LIMIT-0}) to avoid a parsing warning.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
Dockerfile |
Upgrades the HAProxy base image to 3.2-alpine. |
haproxy.cfg |
Tweaks MQTT rate-limit env expansion to avoid a HAProxy 3.2 parsing warning. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
129
to
132
| .if defined(MQTT_RATE_LIMIT) | ||
| # Rate limiting | ||
| acl too_fast fe_sess_rate ge "${MQTT_RATE_LIMIT}" | ||
| acl too_fast fe_sess_rate ge "${MQTT_RATE_LIMIT-0}" | ||
| tcp-request connection reject if too_fast |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested on test server and seems to work, just a minor
haproxy.cfgchange needed to avoid a parsing warning