Skip to content

Conversation

@ezio416
Copy link

@ezio416 ezio416 commented Jul 11, 2025

now in a separate PR and improved a bit :)
implements #34

@codecat
Copy link
Member

codecat commented Jul 11, 2025

We may want to add more exports, if we want to make this something people can depend on. Just having 1 thing seems a little awkward.

Additionally, I question having 2 separate functions for the same purpose, one being an async version and one simply running the async version with startnew - I personally think we should leave that last part up to the plugin developer.

@ezio416
Copy link
Author

ezio416 commented Jul 11, 2025

I tried to think of other potential exports we might want but couldn't. Installing should probably only be done by the manager, I don't see a reason to export anything to do with the cache, and I don't see anything else that could be very useful

@ezio416
Copy link
Author

ezio416 commented Aug 14, 2025

bump :)

@codecat
Copy link
Member

codecat commented Aug 16, 2025

If this PR is just to get the cache sync to play nice on plugin removal, I think we need a different approach. Why not expose an export that calls PluginCache::Sync?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants