-
Notifications
You must be signed in to change notification settings - Fork 9
add exports to uninstall plugin #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
We may want to add more exports, if we want to make this something people can depend on. Just having 1 thing seems a little awkward. Additionally, I question having 2 separate functions for the same purpose, one being an async version and one simply running the async version with |
|
I tried to think of other potential exports we might want but couldn't. Installing should probably only be done by the manager, I don't see a reason to export anything to do with the cache, and I don't see anything else that could be very useful |
|
bump :) |
|
If this PR is just to get the cache sync to play nice on plugin removal, I think we need a different approach. Why not expose an export that calls |
now in a separate PR and improved a bit :)
implements #34