Fix accidentally-escaped newlines in ABC music demo #1004
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Member
|
Thank you :) |
Member
|
And thank you for your code-input library |
Contributor
Author
You're welcome. By the way, I'd very much appreciate it if you could give me your ideas about the future direction of code-input.js at WebCoder49/code-input#190 when you have time, @mikebarkmin. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firstly, I love this compilation of libre educational tools into an easy-to-deliver notebook format!
I noticed the key signature of "Cooley's Long" in https://hyperbook.openpatch.org/elements/abc-music was not being recognised, and neither was the subtitle "reel". This is because the lines defining these were not added as new lines, but instead with "\n" instead of the new line character.
This PR fixes that.