-
Notifications
You must be signed in to change notification settings - Fork 133
One big beautiful pull request #1113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
by fixing the code order in PlayerVehicleSyncHandler, moving validation checks first
by fixing the code order in updateFromDriverSync, moving pure validations first
eliminating areas for abuse, like in SA-MP server
but also add a check for train carriages, since they always consider unstreamed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Vertified
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, this PR is like taking a messy plate of spaghetti code, untangling the noodles, and putting them back in order before anyone chokes on them. 🍝
The fixes make total sense -- moving validation checks before side effects is the programming equivalent of washing your hands before eating, not after. Also, I appreciate the cheater smackdown -- no more ‘free teleport to anywhere’ passenger perks.
Overall: looking really good. Clean, logical, and it closes some pretty nasty loopholes. Thanks for making vehicle sync less of a clown car. 🚗🤡
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
waowieee
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gud
Uh oh!
There was an error while loading. Please reload this page.