Open
Conversation
- Wrote new method to strip version number from bundled OWAs. - Included tests. - This PR is dependent on another PR in `generator-openmrs-owa` by the same name, `CB-164`, which adds version number to newly generated OWAs.
Member
|
Can you include the ticket id in the commit message as advised here? https://wiki.openmrs.org/display/docs/Pull+Request+Tips |
- Wrote new method to strip version number from bundled OWAs. - Included tests. - This PR is dependent on another PR in `generator-openmrs-owa` by the same name, `CB-164`, which adds version number to newly generated OWAs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CB-164 Adding version number to bundled OWA file name
Description of what I changed
Added an OWA Util that will strip the version number from a bundled OWA if the version number is present.
Another PR in
generator-openmrs-owaby the same name (CB-164) allows for newly generated OWA's to contain the version number in the filename when packaged.Issue I worked on
see https://issues.openmrs.org/browse/CB-164
Checklist:
My pull request only contains ONE single commit
(the number above, next to the 'Commits' tab is 1).
No? -> read here on how to squash multiple commits into one
My IDE is configured to follow the code style of this project.
I have added tests to cover my changes. (If you refactored
existing code that was well tested you do not have to add tests)
I ran
mvn clean packageright before creating this pull request andadded all formatting changes to my commit.
All new and existing tests passed.
My pull request is based on the latest changes of the master branch.