Repository navigation
Conversation
…kflow on a given date and making it the default behavior of the <workflowstate/> tag
Contributor
Author
mogoodrich
approved these changes
Apr 6, 2020
mogoodrich
left a comment
mogoodrich
left a comment
Member
There was a problem hiding this comment.
Looks good to me, I added one note for a comment... are you ready for me to merge?
|
|
||
| //if there was none | ||
| if (patientProgram == null) { | ||
| //fall back to old behavior for lookup |
Member
There was a problem hiding this comment.
Let's add a reference to ticket HTML-720 for people who want to understand the details.
Member
|
@mks-d same question here as on the other PR... are you able to test if we merge this in? Thanks! |
|
@kml27 kindly fix the merge conflicts ,so that @mogoodrich can merge this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adding new method to get patient program enrollment by workflow on a given date and making it the default behavior of the tag
Description of what I changed
and HtmlSubmissionActions.transitionToState now use ProgramOnDate variation to get patient program in HtmlFormEntryUtil.
Related unit tests.
Issue I worked on
see https://issues.openmrs.org/browse/HTML-720
Checklist: I completed these to help reviewers :)
My pull request only contains ONE single commit
(the number above, next to the 'Commits' tab is 1).
No? -> read here on how to squash multiple commits into one
My IDE is configured to follow the code style of this project.
No? Unsure? -> configure your IDE, format the code and add the changes with
git add . && git commit --amendI have added tests to cover my changes. (If you refactored
existing code that was well tested you do not have to add tests)
No? -> write tests and add them to this commit
git add . && git commit --amendI ran
mvn clean packageright before creating this pull request andadded all formatting changes to my commit.
No? -> execute above command
All new and existing tests passed.
No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.
My pull request is based on the latest changes of the master branch.
No? Unsure? -> execute command
git pull --rebase upstream master