Add Font Awesome!#9
Open
melroy89 wants to merge 1 commit intoopenmaptiles:gh-pagesfrom
melroy89:gh-pages
Open
Conversation
This was referenced Dec 25, 2018
Author
|
Merge? |
|
Any updates on this PR? |
Author
|
I would like to get it merged in. But nobody is maintaining this repository!!? Hello? |
Member
|
Hey, several notes/questions:
Ideally, clean up the PR to add only the original ttfs/otfs the same way as other fonts are added and let them be generated into PFBs with the same script as the rest of the fonts.. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Font Awesome is free (also for commercial use):
https://fontawesome.com/free
Support Font Awesome out of the box:
mapbox/mapbox-gl-js#3605 (comment)
mapbox/mapbox-gl-styles#241
This makes it possible to use Font-Awesome icons in the text-field. So you can use font awesome icons and scale the image up as much as you want (and the icon keeps sharp)!
Using Font awesome icons also makes it possible to color the icons.
Example using geojson data & Font Awesome + color icon: