feat: Implement tracing for major sandbox api#308
Open
verma-garv wants to merge 3 commits into
Open
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome @verma-garv! It looks like this is your first PR to openkruise/agents 🎉 |
Signed-off-by: Garv Verma <garvverma09@gmail.com>
Signed-off-by: Garv Verma <garvverma09@gmail.com>
verma-garv
force-pushed
the
feat_enable_tracing
branch
from
4010a46 to
6cc7811
Compare
Signed-off-by: Garv Verma <garvverma09@gmail.com>
|
@verma-garv: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Author
|
Hey @DCchoudhury15, can you help me with it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
Implemented execution-level OpenTelemetry tracing at the sandbox manager business-logic layer for sandbox creation and pause flows.
This adds spans for ClaimSandbox (template create path), CloneSandbox (checkpoint-restore create path), and PauseSandbox, with structured attributes, milestone events, error status recording, and timing metrics for better internal observability.
Ⅱ. Does this pull request fix one issue?
fixes #23
Ⅲ. Describe how to verify it
Run sandbox create (template and checkpoint-restore) and pause operations, then check your trace backend (Jaeger/OTLP) for spans
sandbox.claim,sandbox.clone, andsandbox.pausewith expected events/attributes.