Skip to content

8376836: Fix mistakes in FX API docs #2239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
nlisker wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

8376836: Fix mistakes in FX API docs #2239

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6ac20e3
Fix typo in TreeView documentation
nlisker Aug 1, 2026
89c8250
Update Scrollpane documentation for fitToWidth and fitToHeight
nlisker Aug 1, 2026
83d796c
Fix typo in JavaFXBuilderFactory.java comment
nlisker Aug 1, 2026
9223820
Fix comments in Collation
nlisker Aug 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions modules/javafx.controls/src/main/java/javafx/scene/control/ScrollPane.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,9 +353,9 @@ public final DoubleProperty vmaxProperty() {
return vmax;
}
/**
* If true and if the contained node is a Resizable, then the node will be
* If true and if the contained node is {@link Node#isResizable resizable}, then the node will be
* kept resized to match the width of the ScrollPane's viewport. If the
* contained node is not a Resizable, this value is ignored.
* contained node is not resizable, this value is ignored.
*/
private BooleanProperty fitToWidth;
public final void setFitToWidth(boolean value) {
Expand Down Expand Up @@ -390,9 +390,9 @@ public String getName() {
return fitToWidth;
}
/**
* If true and if the contained node is a Resizable, then the node will be
* If true and if the contained node is {@link Node#isResizable resizable}, then the node will be
* kept resized to match the height of the ScrollPane's viewport. If the
* contained node is not a Resizable, this value is ignored.
* contained node is not resizable, this value is ignored.
*/
private BooleanProperty fitToHeight;
public final void setFitToHeight(boolean value) {
Expand Down
2 changes: 1 addition & 1 deletion modules/javafx.controls/src/main/java/javafx/scene/control/TreeView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@
* description of how to write custom Cells.
*
* <h3>Warning: Nodes should not be inserted directly into the TreeView cells</h3>
* {@code TreeView} allows for it's cells to contain elements of any type, including
* {@code TreeView} allows for its cells to contain elements of any type, including
* {@code Node} instances. Putting nodes into
* the TreeView cells is <strong>strongly discouraged</strong>, as it can
* lead to unexpected results.
Expand Down
2 changes: 1 addition & 1 deletion modules/javafx.fxml/src/main/java/javafx/fxml/JavaFXBuilderFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ public JavaFXBuilderFactory(ClassLoader classLoader) {

/**
* Returns the builder for the specified type, or null if no builder is
* used. Most classes will note use a builder.
* used. Most classes will not use a builder.
*
* @param type the class being looked up
*
Expand Down
6 changes: 3 additions & 3 deletions modules/javafx.graphics/src/main/java/javafx/print/Collation.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,15 +35,15 @@
public enum Collation {

/**
* The same numbered pages are consecutive in the output,
* For example: 2 copies of a document with 2 pages is printed :
* The same numbered pages are consecutive in the output.
* For example, 2 copies of a document with 2 pages is printed:
* Page 1, Page 1, Page 2, Page 2.
*/
UNCOLLATED,

/**
* Each copy of a document is printed together.
* FOr example: 2 copies of a document with 2 pages is printed :
* For example, 2 copies of a document with 2 pages is printed:
* Page 1, Page 2, Page 1, Page 2.
*/
COLLATED
Expand Down