8389211: Fix HLS Live issues found during testing of JDK-8331458 and various live streams - #2227
Open
sashamatveev wants to merge 1 commit into
Open
8389211: Fix HLS Live issues found during testing of JDK-8331458 and various live streams#2227sashamatveev wants to merge 1 commit into
sashamatveev wants to merge 1 commit into
Conversation
…various live streams
|
👋 Welcome back almatvee! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
The total number of required reviews for this PR has been set to 2 based on the presence of this label: |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed issue when variant playlist was not detected as live even it was live. Playlist with variant playlists was detected correctly as live.
BYTEsegment vsTIME, soqtdemuxwill handle initial start time. Live streams will not start with 0 PTS as on demand.javasourcewill reportGST_CLOCK_TIME_NONEfor unknown duration instead of large negative number.#EXT-X-MEDIAstreams will be seek to last segment similar to streams without#EXT-X-MEDIAwhen seek to the end.Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/2227/head:pull/2227$ git checkout pull/2227Update a local copy of the PR:
$ git checkout pull/2227$ git pull https://git.openjdk.org/jfx.git pull/2227/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2227View PR using the GUI difftool:
$ git pr show -t 2227Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/2227.diff
Using Webrev
Link to Webrev Comment