Skip to content

8389211: Fix HLS Live issues found during testing of JDK-8331458 and various live streams - #2227

Open
sashamatveev wants to merge 1 commit into
openjdk:masterfrom
sashamatveev:JDK-8389211
Open

8389211: Fix HLS Live issues found during testing of JDK-8331458 and various live streams#2227
sashamatveev wants to merge 1 commit into
openjdk:masterfrom
sashamatveev:JDK-8389211

Conversation

@sashamatveev

@sashamatveev sashamatveev commented Jul 29, 2026

Copy link
Copy Markdown
Member
  • Changed on how HLS select media file index when variant playlist is switched. It was based on file name, but it is not reliable, since file names are not guaranteed to match. Instead, index is adjusted based on sequence number which should not drift more than +/- 1 when switch is done. Sequence number is like index of first segment file in live streams.
    Fixed issue when variant playlist was not detected as live even it was live. Playlist with variant playlists was detected correctly as live.
  • Fixed reload time. Thread sleep is expecting milliseconds, and we provided (seconds / 2) as milliseconds without conversion. As have resulted we were requesting playlist way too often.
  • Redone mechanism on how we are waiting for live segments to be added. Old approach had a bug with semaphore and if we added two segments in one run it will cause code to assume that we have segments when we did not. As a result, EOS was signaled for live streams. This issue does not reproduce often but might happen.
  • Old playlist data will be cleared when we are switching bitrate, otherwise we will attempt to play old segments which are gone long time.
  • Fixed start time for live streams by sending BYTE segment vs TIME, so qtdemux will handle initial start time. Live streams will not start with 0 PTS as on demand.
  • javasource will report GST_CLOCK_TIME_NONE for unknown duration instead of large negative number.
  • #EXT-X-MEDIA streams will be seek to last segment similar to streams without #EXT-X-MEDIA when seek to the end.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

  • JDK-8389211: Fix HLS Live issues found during testing of JDK-8331458 and various live streams (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/2227/head:pull/2227
$ git checkout pull/2227

Update a local copy of the PR:
$ git checkout pull/2227
$ git pull https://git.openjdk.org/jfx.git pull/2227/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2227

View PR using the GUI difftool:
$ git pr show -t 2227

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/2227.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper

bridgekeeper Bot commented Jul 29, 2026

Copy link
Copy Markdown

👋 Welcome back almatvee! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented Jul 29, 2026

Copy link
Copy Markdown

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk Bot added the rfr Ready for review label Jul 29, 2026
@openjdk

openjdk Bot commented Jul 29, 2026

Copy link
Copy Markdown

The total number of required reviews for this PR has been set to 2 based on the presence of this label: rfr. This can be overridden with the /reviewers command.

@mlbridge

mlbridge Bot commented Jul 29, 2026

Copy link
Copy Markdown

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rfr Ready for review

Development

Successfully merging this pull request may close these issues.

1 participant