-
Notifications
You must be signed in to change notification settings - Fork 165
8365560: [8u] ppc64le MaxRAM default is too low at 4GiB #675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back jdowland! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
/approval request trivial change, ready for review. TIA |
Please only ask for approval once the patch got review-approved. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay
|
/approval reviewed, trivial change, aligns with JDK11+, ready for review. Thanks! |
@jmtd usage: |
/approval request reviewed, trivial change, aligns with JDK11+, ready for review. Thanks! (I'll get there eventually) |
Bump the default value of MaxRAM from 4GiB to 128GiB on PPC64, aligning with the other 64bit ports.
This change was made as part of a bundle of clean-ups in JDK11 (JDK-8194814), but here I do not attempt to backport the other changes.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/675/head:pull/675
$ git checkout pull/675
Update a local copy of the PR:
$ git checkout pull/675
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/675/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 675
View PR using the GUI difftool:
$ git pr show -t 675
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/675.diff
Using Webrev
Link to Webrev Comment