Skip to content

8365560: [8u] ppc64le MaxRAM default is too low at 4GiB #675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jmtd
Copy link
Contributor

@jmtd jmtd commented Aug 14, 2025

Bump the default value of MaxRAM from 4GiB to 128GiB on PPC64, aligning with the other 64bit ports.

This change was made as part of a bundle of clean-ups in JDK11 (JDK-8194814), but here I do not attempt to backport the other changes.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • JDK-8365560 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8365560: [8u] ppc64le MaxRAM default is too low at 4GiB (Bug - P4 - Requested)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/675/head:pull/675
$ git checkout pull/675

Update a local copy of the PR:
$ git checkout pull/675
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/675/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 675

View PR using the GUI difftool:
$ git pr show -t 675

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/675.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 14, 2025

👋 Welcome back jdowland! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 14, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added rfr Pull request is ready for review approval Requires approval; will be removed when approval is received labels Aug 14, 2025
@mlbridge
Copy link

mlbridge bot commented Aug 14, 2025

Webrevs

@openjdk openjdk bot removed the approval Requires approval; will be removed when approval is received label Aug 14, 2025
@jmtd jmtd changed the title 8365560: [jdk8u] ppc64le MaxRAM default is too low at 4GiB 8365560: [8u] ppc64le MaxRAM default is too low at 4GiB Aug 14, 2025
@jmtd
Copy link
Contributor Author

jmtd commented Aug 14, 2025

/approval request trivial change, ready for review. TIA

@openjdk
Copy link

openjdk bot commented Aug 14, 2025

@jmtd
8365560: The approval request has been created successfully.

@jerboaa
Copy link
Contributor

jerboaa commented Aug 14, 2025

/approval request trivial change, ready for review. TIA

Please only ask for approval once the patch got review-approved. Thanks!

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received and removed approval Requires approval; will be removed when approval is received labels Aug 14, 2025
Copy link
Member

@tstuefe tstuefe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay

@openjdk
Copy link

openjdk bot commented Aug 15, 2025

⚠️ @jmtd This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@jmtd
Copy link
Contributor Author

jmtd commented Aug 15, 2025

/approval reviewed, trivial change, aligns with JDK11+, ready for review. Thanks!

@openjdk
Copy link

openjdk bot commented Aug 15, 2025

@jmtd usage: /approval [<id>] (request|cancel) [<text>]

@jmtd
Copy link
Contributor Author

jmtd commented Aug 15, 2025

/approval request reviewed, trivial change, aligns with JDK11+, ready for review. Thanks!

(I'll get there eventually)

@openjdk
Copy link

openjdk bot commented Aug 15, 2025

@jmtd
8365560: The approval request has been updated successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Aug 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval Requires approval; will be removed when approval is received rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

3 participants