Skip to content

8328279: Convert java/awt/Cursor/CursorOverlappedPanelsTest test to main #3803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Aug 3, 2025

I backport this for parity with 17.0.17-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8328279 needs maintainer approval

Issue

  • JDK-8328279: Convert java/awt/Cursor/CursorOverlappedPanelsTest test to main (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3803/head:pull/3803
$ git checkout pull/3803

Update a local copy of the PR:
$ git checkout pull/3803
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3803/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3803

View PR using the GUI difftool:
$ git pr show -t 3803

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3803.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 3, 2025

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 3, 2025

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8328279: Convert java/awt/Cursor/CursorOverlappedPanelsTest test to main

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 2094ff3c7ad829355bf13760d9a19b37649b3517 8328279: Convert java/awt/Cursor/CursorOverlappedPanelsTest test to main Aug 3, 2025
@openjdk
Copy link

openjdk bot commented Aug 3, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Aug 3, 2025
@openjdk
Copy link

openjdk bot commented Aug 3, 2025

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 3, 2025
@mlbridge
Copy link

mlbridge bot commented Aug 3, 2025

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Aug 4, 2025

GHA failure: unrelated.
corss compile failures fixed by JDK-8363965: GHA: Switch cross-compiling sysroots to Debian bookworm

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 4, 2025
@GoeLin
Copy link
Member Author

GoeLin commented Aug 5, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Aug 5, 2025

Going to push as commit a81169a.
Since your change was applied there have been 13 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 5, 2025
@openjdk openjdk bot closed this Aug 5, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 5, 2025
@openjdk
Copy link

openjdk bot commented Aug 5, 2025

@GoeLin Pushed as commit a81169a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant