-
Notifications
You must be signed in to change notification settings - Fork 227
8340185: Use make -k on GHA to catch more build errors #3792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back shade! A progress list of the required criteria for merging this PR into |
@shipilev This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
This backport pull request has now been updated with issue from the original commit. |
|
92520b2
to
01018ec
Compare
@shipilev Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
/approval request Quality of life improvement for GHA. Applies cleanly. GHA passes. |
Push approval granted. /integrate |
Going to push as commit 0385265.
Your commit was automatically rebased without conflicts. |
Improves GHA usability.
Additional testing:
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3792/head:pull/3792
$ git checkout pull/3792
Update a local copy of the PR:
$ git checkout pull/3792
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3792/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3792
View PR using the GUI difftool:
$ git pr show -t 3792
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3792.diff
Using Webrev
Link to Webrev Comment