Skip to content

Conversation

@MBaesken
Copy link
Member

@MBaesken MBaesken commented Jan 8, 2026

Currently Platform.java from the audio coding uses its own native code to get the endianness info of the underlying hardware it runs on.
See


But we can reuse existing Java JDK code e.g. from nio.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8374727: Audio configuration Platform class - use nio for getting endianness of the underlying platform (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/29113/head:pull/29113
$ git checkout pull/29113

Update a local copy of the PR:
$ git checkout pull/29113
$ git pull https://git.openjdk.org/jdk.git pull/29113/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 29113

View PR using the GUI difftool:
$ git pr show -t 29113

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/29113.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 8, 2026

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 8, 2026

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8374727: Audio configuration Platform class - use nio for getting endianness of the underlying platform

Reviewed-by: prr, kizune

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 28 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title JDK-8374727: Audio configuration Platform class - use nio for getting endianness of the underlying platform 8374727: Audio configuration Platform class - use nio for getting endianness of the underlying platform Jan 8, 2026
@openjdk
Copy link

openjdk bot commented Jan 8, 2026

@MBaesken The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 8, 2026
@mlbridge
Copy link

mlbridge bot commented Jan 8, 2026

Webrevs

@MBaesken
Copy link
Member Author

MBaesken commented Jan 8, 2026

ByteOrder.nativeOrder() is already used for the BE/LE checks across the JDK, see
https://github.com/search?q=repo%3Aopenjdk%2Fjdk++%22ByteOrder.nativeOrder%28%29+%3D%3D%22&type=code

(maybe we should also have something like public static boolean ByteOrder.isLittleEndian() / public static boolean ByteOrder.isBigEndian() to shorten those checks a bit, but this is out of the scope of this PR)

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client [email protected] ready Pull request is ready to be integrated rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

3 participants