Skip to content

Conversation

@erikj79
Copy link
Member

@erikj79 erikj79 commented Jan 7, 2026

This pull request contains a backport of commit 383fe1ef from the openjdk/jdk repository.

The commit being backported was authored by Erik Joelsson on 7 Jan 2026 and was reviewed by Tim Bell and Aleksey Shipilev.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8374642: EscapeHash macro fails with GNU make 4.3 and 4.4 (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/29099/head:pull/29099
$ git checkout pull/29099

Update a local copy of the PR:
$ git checkout pull/29099
$ git pull https://git.openjdk.org/jdk.git pull/29099/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 29099

View PR using the GUI difftool:
$ git pr show -t 29099

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/29099.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 7, 2026

👋 Welcome back erikj! A progress list of the required criteria for merging this PR into jdk26 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 7, 2026

@erikj79 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8374642: EscapeHash macro fails with GNU make 4.3 and 4.4

Reviewed-by: mikael, iris

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the jdk26 branch:

  • d0a3ba9: 8374632: Broken list layout in the man page of jlink

Please see this link for an up-to-date comparison between the source branch of this pull request and the jdk26 branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the jdk26 branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 383fe1efc3a23385b8576e20f458f91085c6325e 8374642: EscapeHash macro fails with GNU make 4.3 and 4.4 Jan 7, 2026
@openjdk
Copy link

openjdk bot commented Jan 7, 2026

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required build [email protected] labels Jan 7, 2026
@openjdk
Copy link

openjdk bot commented Jan 7, 2026

@erikj79 The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 7, 2026
@mlbridge
Copy link

mlbridge bot commented Jan 7, 2026

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 8, 2026
@erikj79
Copy link
Member Author

erikj79 commented Jan 8, 2026

/integrate

@openjdk
Copy link

openjdk bot commented Jan 8, 2026

Going to push as commit 0981794.
Since your change was applied there have been 6 commits pushed to the jdk26 branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 8, 2026
@openjdk openjdk bot closed this Jan 8, 2026
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 8, 2026
@openjdk
Copy link

openjdk bot commented Jan 8, 2026

@erikj79 Pushed as commit 0981794.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base build [email protected] clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants