8364927: Add @requires annotation to TestReclaimStringsLeaksMemory.java #26766
+30
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates
TestReclaimStringsLeaksMemory.java
to properly guard against unsupported GC arguments.Previously, the test only checked
@requires vm.gc == "null"
.The fix separates the tests and adds explicit
@requires
clauses for each GC configuration to ensure the test only runs when supported.This prevents test failures on VMs that do not support the specified GC.
(This is my first contribution to the JDK. Thank you for your review and guidance.)
Progress
Error
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26766/head:pull/26766
$ git checkout pull/26766
Update a local copy of the PR:
$ git checkout pull/26766
$ git pull https://git.openjdk.org/jdk.git pull/26766/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 26766
View PR using the GUI difftool:
$ git pr show -t 26766
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26766.diff