8362979: C2 fails with unexpected node in SuperWord truncation: CmpLTMask, RoundF

[jaskarth]

Hi all,
This is a fix for a debug assert failure in SuperWord truncation for CmpLTMask and RoundF nodes, as discovered by CTW in the linked JBS report. I've added the nodes to the switch, and added reduced test cases. I've made a similar fix for RoundD nodes as well. Thanks!

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8362979: C2 fails with unexpected node in SuperWord truncation: CmpLTMask, RoundF (Bug - P3)

Reviewers

• Christian Hagedorn (@chhagedorn - Reviewer)
• Tobias Hartmann (@TobiHartmann - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26494/head:pull/26494
$ git checkout pull/26494

Update a local copy of the PR:
$ git checkout pull/26494
$ git pull https://git.openjdk.org/jdk.git pull/26494/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26494

View PR using the GUI difftool:
$ git pr show -t 26494

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26494.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jkarthikeyan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@jaskarth This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8362979: C2 fails with unexpected node in SuperWord truncation: CmpLTMask, RoundF

Reviewed-by: chagedorn, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

• e307b5c: 8363584: Sort share/utilities includes
• 4189fcb: 8362596: RISC-V: Improve _vectorizedHashCode intrinsic
• 3263361: 8360981: Remove use of Thread.stop in test/jdk/java/net/Socket/DeadlockTest.java

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@jaskarth The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (cec931f3)

[chhagedorn]

Looks good!

[TobiHartmann]

Looks good to me too. Thanks for quickly jumping on this!

[jaskarth]

Thanks for the reviews!

/integrate

[jaskarth]

Hmm, looks like the bot didn't catch it. Retrying...
/integrate

[openjdk]

Going to push as commit ea0b49c.
Since your change was applied there have been 16 commits pushed to the master branch:

• fe4d7f8: 8360507: JPKG002-006: SigningPackageTest: appOutput.txt cannot be found in user home directory and output doesn't contain: origin=Developer ID Application: jpackage.openjdk.java.net
• f53d051: 8340312: sun.security.ssl.SSLLogger uses incorrect log level ALL for finest log events
• 70ebb5e: 8364019: Add alignment precondition to Universe::reserve_heap
• ... and 13 more: https://git.openjdk.org/jdk/compare/8fcbb110e9941af5fe162c6affff36e0bf652bda...master

Your commit was automatically rebased without conflicts.

[openjdk]

@jaskarth Pushed as commit ea0b49c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[openjdk]

@jaskarth The command integrate can only be used in open pull requests.