8362279: [vectorapi] VECTOR_OP_SUADD needs reduction support

[igraves]

Adding SUADD to reduction support in the Vector API as it is now treated as an associative operator.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8362279: [vectorapi] VECTOR_OP_SUADD needs reduction support (Bug - P4)

Reviewers

• Jatin Bhateja (@jatin-bhateja - Reviewer)
• Quan Anh Mai (@merykitty - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26486/head:pull/26486
$ git checkout pull/26486

Update a local copy of the PR:
$ git checkout pull/26486
$ git pull https://git.openjdk.org/jdk.git pull/26486/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26486

View PR using the GUI difftool:
$ git pr show -t 26486

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26486.diff

[igraves]

@merykitty If you could review, thanks!

[bridgekeeper]

👋 Welcome back igraves! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@igraves This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8362279: [vectorapi] VECTOR_OP_SUADD needs reduction support

Reviewed-by: jbhateja, qamai

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 152 new commits pushed to the master branch:

• b4028c9: 8362482: [TESTBUG] serviceability/HeapDump/UnmountedVThreadNativeMethodAtTop.java: System.gc() does not provide full GC
• 08b0b34: 8361715: (bf) Improve java/nio/Buffer/GetChars.java and migrate to JUnit
• 7bf4c60: 8364120: RISC-V: unify the usage of MacroAssembler::instruction_size
• ... and 149 more: https://git.openjdk.org/jdk/compare/820263e48abf3ddce9506eb19872871aa3ea8b50...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@igraves To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels

• build
• client
• compiler
• core-libs
• graal
• hotspot
• hotspot-compiler
• hotspot-gc
• hotspot-jfr
• hotspot-runtime
• i18n
• ide-support
• javadoc
• jdk
• jmx
• net
• nio
• security
• serviceability
• shenandoah

[jatin-bhateja]

Hi Ian,

LGTM, thanks for the Z3 proof https://github.com/igraves/z3proofs/blob/main/z3proofs/saturated_addition.py

I have assigned intrinsificiation JBS to myself
https://bugs.openjdk.org/browse/JDK-8362280

Best Regards

[merykitty]

Thanks, LGTM.

[igraves]

/integrate

[openjdk]

Going to push as commit 57d02d9.
Since your change was applied there have been 182 commits pushed to the master branch:

• a2e86ff: 8364037: Sort share includes: adlc, libadt, metaprogramming
• e2feff8: 8355177: Speed up StringBuilder::append(char[]) via Unsafe::copyMemory
• 16da81e: 8360817: [ubsan] zDirector select_worker_threads - outside the range of representable values issue
• ... and 179 more: https://git.openjdk.org/jdk/compare/820263e48abf3ddce9506eb19872871aa3ea8b50...master

Your commit was automatically rebased without conflicts.

[openjdk]

@igraves Pushed as commit 57d02d9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.